Add comparison operators and bool handling in arithmetic ops #1541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klecki
changed the title
|
!build |
|
CI MESSAGE: [1018166]: BUILD STARTED |
|
CI MESSAGE: [1018166]: BUILD PASSED |
JanuszL
reviewed
Dec 5, 2019
| auto *result1 = ws.OutputRef<GPUBackend>(1).data<int32_t>(); | ||
| vector<int32_t> result1_cpu(batch_size * tensor_elements); | ||
|
|
||
| MemCopy(result1_cpu.data(), result1, batch_size * tensor_elements * sizeof(int)); |
JanuszL
reviewed
Dec 5, 2019
| @@ -27,6 +27,29 @@ | |||
|
|
|||
| namespace dali { | |||
|
|
|||
| template <ArithmeticOp op, typename Result, typename Input0> | |||
There was a problem hiding this comment.
Why not just input, in other cases we have left and right. And I don't think we will have 3 arguments arithmetic operators.
JanuszL
reviewed
Dec 5, 2019
JanuszL
reviewed
Dec 6, 2019
awolant
approved these changes
Dec 10, 2019
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
|
CI MESSAGE: [1029807]: BUILD STARTED |
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
|
CI MESSAGE: [1029815]: BUILD STARTED |
mzient
reviewed
Dec 12, 2019
| try: | ||
| self.length = len(types) | ||
| except TypeError: | ||
| types = (types,) | ||
| kinds = (kinds,) | ||
| self.length = 1 | ||
| if not disallow_zeros: |
There was a problem hiding this comment.
Suggestion: how about a sanity check that disallow_zeros is False when generating bools?
|
CI MESSAGE: [1029815]: BUILD FAILED |
|
!build |
|
CI MESSAGE: [1030422]: BUILD STARTED |
|
CI MESSAGE: [1030422]: BUILD FAILED |
|
CI MESSAGE: [1030422]: BUILD PASSED |
JanuszL
approved these changes
Dec 13, 2019
Co-Authored-By: Janusz Lisiecki <39967756+JanuszL@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why we need this PR?
It adds comparisons and boolean handling to DALI expressions/arithmetic ops.
What happened in this PR?
The boolean type was registered for type promotions, support for Constants with booleans and native python
boolwas added.Implementation for all possible comparisons was added, with safe handling of comparisons between singed and unsigned integers.
Tests were extended and some subset of tests was marked as 'slow' and split into a L1 level test.
JIRA TASK: [DALI-1178]