Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stream usage in HSV and BrighnessContrast. #1566

Merged
merged 1 commit into from
Dec 11, 2019
Merged

Fix stream usage in HSV and BrighnessContrast. #1566

merged 1 commit into from
Dec 11, 2019

Conversation

mzient
Copy link
Contributor

@mzient mzient commented Dec 11, 2019

Signed-off-by: Michal Zientkiewicz michalz@nvidia.com

Why we need this PR?

Pick one

  • It fixes a bug: not setting CUDA stream in HSV and BrighnessContrast operators

What happened in this PR?

  • Explain solution of the problem, new feature added.
  • What is most important part that reviewers should focus on?
    • stream is now set in the context
  • What was changed, added, removed?
    • additionally, output shape doesn't get two (!) additional copies when it's already persistent and returned by reference
  • Was this PR tested? How?
    • old tests apply
  • Were docs and examples updated, if necessary?
    • N/A

JIRA TASK: N/A

@mzient
Fix stream usage in HSV and BrighnessContrast.
5dd4f6c 
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
@mzient
Copy link
Contributor Author

mzient commented Dec 11, 2019

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1028453]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1028453]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1028453]: BUILD PASSED

@klecki klecki merged commit 427a752 into NVIDIA:master Dec 11, 2019
@klecki klecki mentioned this pull request Dec 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klecki klecki klecki approved these changes

@awolant awolant awolant approved these changes

@jantonguirao jantonguirao Awaiting requested review from jantonguirao

@szalpal szalpal Awaiting requested review from szalpal

@JanuszL JanuszL Awaiting requested review from JanuszL

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mzient @dali-automaton @klecki @awolant