-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporary fix due to missing PILLOW_VERSION symbol when using torchvision #1626
Conversation
…sion Signed-off-by: Joaquin Anton <janton@nvidia.com>
d5a7263
to
f0d01c3
Compare
!build |
CI MESSAGE: [1056003]: BUILD STARTED |
The torchvision fix is due out early next week (pytorch/vision#1712):
|
CI MESSAGE: [1056003]: BUILD FAILED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check my coment
It won't help us much as we need a version for CUDA 9 which is no longer maintained and won't be updated. |
@@ -1,6 +1,7 @@ | |||
#!/bin/bash -e | |||
# used pip packages | |||
pip_packages="torchvision torch" | |||
# TODO(janton): remove explicit pillow version installation when torch fixes the issue with PILLOW_VERSION not being defined | |||
pip_packages="pillow=6.2.2 torchvision torch" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pip_packages="pillow=6.2.2 torchvision torch" | |
pip_packages="pillow==6.2.2 torchvision torch" |
Signed-off-by: Joaquin Anton <janton@nvidia.com>
!build |
CI MESSAGE: [1060558]: BUILD STARTED |
CI MESSAGE: [1060558]: BUILD PASSED |
torchvision v0.5.0 has been released with the fix:
|
@hugovk - it is not available for CUDA9 so we need to stick to this workaround. |
Signed-off-by: Joaquin Anton janton@nvidia.com
Why we need this PR?
Pick one, remove the rest
https://pillow.readthedocs.io/en/stable/releasenotes/7.0.0.html
What happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
Fixed pillow version to 6.2.2 (the symbol was removed in the next version 7.0.0)
QA test scripts
Everything
CI
N/A
JIRA TASK: [Use DALI-XXXX or NA]