Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary fix due to missing PILLOW_VERSION symbol when using torchvision #1626

Merged
merged 2 commits into from
Jan 7, 2020

Conversation

jantonguirao
Copy link
Contributor

Signed-off-by: Joaquin Anton janton@nvidia.com

Why we need this PR?

Pick one, remove the rest

What happened in this PR?

Fill relevant points, put NA otherwise. Replace anything inside []

  • What solution was applied:
    Fixed pillow version to 6.2.2 (the symbol was removed in the next version 7.0.0)
  • Affected modules and functionalities:
    QA test scripts
  • Key points relevant for the review:
    Everything
  • Validation and testing:
    CI
  • Documentation (including examples):
    N/A

JIRA TASK: [Use DALI-XXXX or NA]

…sion

Signed-off-by: Joaquin Anton <janton@nvidia.com>
@jantonguirao
Copy link
Contributor Author

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1056003]: BUILD STARTED

@hugovk
Copy link

hugovk commented Jan 3, 2020

The torchvision fix is due out early next week (pytorch/vision#1712):

We will be releasing a new version of PyTorch and torchvision early next week, so this should be soon fixed.

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1056003]: BUILD FAILED

Copy link
Contributor

@JanuszL JanuszL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my coment

@JanuszL
Copy link
Contributor

JanuszL commented Jan 3, 2020

The torchvision fix is due out early next week (pytorch/vision#1712):

We will be releasing a new version of PyTorch and torchvision early next week, so this should be soon fixed.

It won't help us much as we need a version for CUDA 9 which is no longer maintained and won't be updated.

@@ -1,6 +1,7 @@
#!/bin/bash -e
# used pip packages
pip_packages="torchvision torch"
# TODO(janton): remove explicit pillow version installation when torch fixes the issue with PILLOW_VERSION not being defined
pip_packages="pillow=6.2.2 torchvision torch"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pip_packages="pillow=6.2.2 torchvision torch"
pip_packages="pillow==6.2.2 torchvision torch"

Signed-off-by: Joaquin Anton <janton@nvidia.com>
@jantonguirao
Copy link
Contributor Author

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1060558]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1060558]: BUILD PASSED

@jantonguirao jantonguirao merged commit ba7d66e into NVIDIA:master Jan 7, 2020
@hugovk
Copy link

hugovk commented Jan 16, 2020

torchvision v0.5.0 has been released with the fix:

  1. Require torchvision>=0.5.0
  2. If Pillow was temporarily pinned, remove the pin

@JanuszL
Copy link
Contributor

JanuszL commented Jan 16, 2020

@hugovk - it is not available for CUDA9 so we need to stick to this workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants