Fix multi-channel fill value check in Erase operator #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joaquin Anton <janton@nvidia.com>
awolant
approved these changes
Jan 20, 2020
|
!build |
|
CI MESSAGE: [1081895]: BUILD STARTED |
JanuszL
approved these changes
Jan 20, 2020
|
CI MESSAGE: [1081895]: BUILD FAILED |
|
CI MESSAGE: [1081895]: BUILD PASSED |
|
Can you add a test to https://github.com/NVIDIA/DALI/blob/master/dali/test/python/test_operator_erase.py for the fixed case? |
Signed-off-by: Joaquin Anton <janton@nvidia.com>
|
!build |
|
CI MESSAGE: [1085132]: BUILD STARTED |
JanuszL
approved these changes
Jan 22, 2020
|
CI MESSAGE: [1085132]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joaquin Anton janton@nvidia.com
Why we need this PR?
Pick one, remove the rest
What happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
fill_valueargument check.fill_valuecan have more than 1 value only if the input layout has a 'C' (channel) dimension*Erase operator
All
N/A
N/A
JIRA TASK: [Use DALI-XXXX or NA]