Add synchronization to read/write operations in image decoder cache #1702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joaquin Anton <janton@nvidia.com>
mzient
reviewed
Jan 30, 2020
| } | ||
|
|
||
| ImageCacheBlob::~ImageCacheBlob() { | ||
| try { | ||
| CUDA_CALL(cudaStreamSynchronize(cache_stream_)); |
There was a problem hiding this comment.
A general remark: doing this try/terminate defeats the debugger.
mzient
reviewed
Jan 30, 2020
| /** | ||
| * @brief Synchronizes internal cache CUDA stream with a provided stream before a cache reading | ||
| * operation | ||
| * @remarks To be called before launching a memory copy from a pointer provided by Get |
There was a problem hiding this comment.
You can also mention here that Add doesn't need extra synchronization.
mzient
approved these changes
Jan 30, 2020
Signed-off-by: Joaquin Anton <janton@nvidia.com>
|
!build |
|
CI MESSAGE: [1099620]: BUILD STARTED |
|
CI MESSAGE: [1099620]: BUILD FAILED |
JanuszL
approved these changes
Jan 30, 2020
Signed-off-by: Joaquin Anton <janton@nvidia.com>
|
!build |
|
CI MESSAGE: [1099763]: BUILD STARTED |
|
CI MESSAGE: [1099763]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joaquin Anton janton@nvidia.com
Why we need this PR?
Pick one, remove the rest
What happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
*Introduced an internal cache stream that it is used to synchronize read/write access
ImageDecoder with cached enabled
Usage of CUDA streams/events
Existing tests
NA
JIRA TASK: [Use DALI-XXXX or NA]