Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds data_ptr method to Tensor and TensorList #1773

Merged
merged 1 commit into from
Mar 2, 2020
Merged

Adds data_ptr method to Tensor and TensorList #1773

merged 1 commit into from
Mar 2, 2020

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Feb 27, 2020

  • adds an ability to expose a raw data pointer form Tensor and TensorList

Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com

Why we need this PR?

Pick one, remove the rest

  • It adds an ability to expose a raw data pointer form Tensor and TensorList

What happened in this PR?

Fill relevant points, put NA otherwise. Replace anything inside []

  • What solution was applied:
    adds an ability to expose a raw data pointer form Tensor and TensorList
  • Affected modules and functionalities:
    backend_impl
  • Key points relevant for the review:
    NA
  • Validation and testing:
    Tests added
  • Documentation (including examples):
    Docstrings are added

In response to #1765

JIRA TASK: [NA]

@JanuszL JanuszL changed the title [WIP] Adds data_ptr method to Tensor and TensorList Adds data_ptr method to Tensor and TensorList Feb 28, 2020
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1158767]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1158767]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1158801]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1158801]: BUILD PASSED

},
R"code(
Returns a tensor at given position in the list.

Parameters
----------
)code")
)code")l
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo. Fixed.

- adds an ability to expose a raw data pointer form Tensor and TensorList
  on CPU and GPU
- adds tests for `data_ptr` which created numpy or cupy arrays form an
  exposed pointers

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@JanuszL JanuszL requested a review from awolant March 2, 2020 12:45
@JanuszL JanuszL merged commit 03373f9 into NVIDIA:master Mar 2, 2020
@JanuszL JanuszL deleted the tensor_pointer branch March 2, 2020 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants