Fix jitter operator illegal memory access #1914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
CI MESSAGE: [1285453]: BUILD STARTED |
mzient
reviewed
Apr 28, 2020
| @@ -38,7 +39,8 @@ Randomizer<GPUBackend>::Randomizer(int seed, size_t len) { | |||
| len_ = len; | |||
| cudaGetDevice(&device_); | |||
| states_ = GPUBackend::New(sizeof(curandState) * len, true); | |||
| initializeStates<<<128, 256>>>(len_, seed, reinterpret_cast<curandState*>(states_)); | |||
| initializeStates<<<std::ceil(len_/static_cast<float>(block_size_)), block_size_>>> | |||
There was a problem hiding this comment.
Suggested change
| initializeStates<<<std::ceil(len_/static_cast<float>(block_size_)), block_size_>>> | |
| initializeStates<<<div_ceil(len_, block_size_), block_size_>>> |
using floating point arithmetic may lead to incorrect results when len_ > 256*2^23
|
CI MESSAGE: [1285453]: BUILD FAILED |
mzient
approved these changes
Apr 28, 2020
- JitterAugment accesses random generator on the GPU beyond allowed range - added a fix to make sure that access to random generator is inside allowed range Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
CI MESSAGE: [1285483]: BUILD STARTED |
|
CI MESSAGE: [1285483]: BUILD PASSED |
jantonguirao
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com
Why we need this PR?
Pick one, remove the rest
What happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
added a fix to make sure that access to random generator is inside allowed range
jitter
NA
CI
NA
In response to #966
JIRA TASK: [NA]