Normalize GPU - pImpl + Bessel's corrections #1981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Add Bessel's correction for standard deviation. Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
mzient
changed the title
|
CI MESSAGE: [1349891]: BUILD STARTED |
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
JanuszL
reviewed
May 27, 2020
| @@ -21,6 +21,7 @@ | |||
| #include "dali/core/convert.h" | |||
| #include "dali/core/format.h" | |||
| #include "dali/core/small_vector.h" | |||
| #include "dali/core/tensor_shape_print.h" | |||
There was a problem hiding this comment.
I must re-check... I'm formatting tensor shape in some error messages and I think the error originated in this file.
There was a problem hiding this comment.
Checked - it is indeed necessary.
|
CI MESSAGE: [1349891]: BUILD PASSED |
JanuszL
reviewed
May 27, 2020
jantonguirao
approved these changes
May 27, 2020
JanuszL
reviewed
May 27, 2020
| * (typically reciprocal of standard deviation or 1/(max-min)). | ||
| * The normalization follows the formula: | ||
| * ``` | ||
| * out[data_idx] = (in[data_idx] - base[param_idx]) * scale[param_idx] * global_scale + shift |
There was a problem hiding this comment.
Maybe you can write how param_idx is calculated.
There was a problem hiding this comment.
I see it is described in L54. Still small info hear would help.
There was a problem hiding this comment.
I explained it in lines 51-57.
JanuszL
approved these changes
May 27, 2020
|
!build |
JanuszL
reviewed
May 27, 2020
| * ``` | ||
| * Where `data_idx` is a position in the data tensor (in, out) and `param_idx` is a position | ||
| * in the base and scale tensors (see below for details). The two additional constants, | ||
| * `global_scale` and `shift` can be used to adjust the result to the ynamic range and resolution |
There was a problem hiding this comment.
Suggested change
| * `global_scale` and `shift` can be used to adjust the result to the ynamic range and resolution | |
| * `global_scale` and `shift` can be used to adjust the result to the dynamic range and resolution |
|
CI MESSAGE: [1350221]: BUILD STARTED |
mzient
force-pushed
the
NormalizeGPU_v2
branch
2 times, most recently
from
c9801aa
to
af66a83
Compare
JanuszL
approved these changes
May 27, 2020
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
|
CI MESSAGE: [1350287]: BUILD STARTED |
|
CI MESSAGE: [1350287]: BUILD FAILED |
|
CI MESSAGE: [1350287]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why we need this PR?
Pick one, remove the rest
What happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
JIRA TASK: DALI-1267