Fix hw_decoder_load=0.0 for ImageDecoder related tests that require deterministic results #2232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awolant
approved these changes
Aug 26, 2020
mzient
approved these changes
Aug 26, 2020
JanuszL
approved these changes
Aug 26, 2020
klecki
reviewed
Aug 26, 2020
dali/test/python/test_pipeline.py
Outdated
| @@ -657,7 +657,7 @@ def __init__(self, batch_size, num_threads, device_id, num_gpus): | |||
| num_threads, | |||
| device_id) | |||
| self.input = ops.CaffeReader(path = caffe_db_folder, shard_id = device_id, num_shards = num_gpus) | |||
| self.decode = ops.ImageDecoder(device = "mixed", output_type = types.RGB) | |||
| self.decode = ops.ImageDecoder(device = "mixed", output_type = types.RGB, hw_decoder_load = 0.0) # Fixing HW load to 0 to be able to compare with ImageDecoderCrop (which uses CUDA decoder only) | |||
There was a problem hiding this comment.
Just a minor comment: can those comments appear in separate lines to not make them so long?
…eterministic results Signed-off-by: Joaquin Anton <janton@nvidia.com>
jantonguirao
force-pushed
the
image_decoder_test_fix_hw_dec_load
branch
from
3b90921
to
6c3a633
Compare
|
!build |
|
CI MESSAGE: [1573298]: BUILD STARTED |
|
CI MESSAGE: [1573298]: BUILD PASSED |
klecki
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joaquin Anton janton@nvidia.com
Why we need this PR?
Pick one, remove the rest
What happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
Fixed hw_decoder_load=0.0 in tests that compare the output of different versions of ImageDecoder.
test_pipeline.py
All
Modified tests
N/A
JIRA TASK: [Use DALI-XXXX or NA]