Add ability to cross-build Python wheels for Jetson #2313

JanuszL · 2020-09-30T13:49:18Z

adds a way to build Python bindings when cross-compiling DALI for Xavier platform
adds a way to generate Python wheel for Xavier

Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com

Why we need this PR?

Pick one, remove the rest

It fixes a bug bug description
It adds new feature needed because of why we need this feature
Refactoring to improve what

What happened in this PR?

Fill relevant points, put NA otherwise. Replace anything inside []

What solution was applied:
[ Explain solution of the problem, a new feature added here. ]
Affected modules and functionalities:
[ Describe here what was changed, added, removed. ]
Key points relevant for the review:
[ Describe here what is the most important part that reviewers should focus on. ]
Validation and testing:
[ Describe here if and how this PR is tested. ]
Documentation (including examples):
[ Describe here if documentation and examples were updated. ]

JIRA TASK: [Use DALI-XXXX or NA]

dali-automaton · 2020-09-30T13:51:35Z

CI MESSAGE: [1666342]: BUILD STARTED

dali-automaton · 2020-09-30T14:55:46Z

CI MESSAGE: [1666342]: BUILD FAILED

dali-automaton · 2020-09-30T16:31:48Z

CI MESSAGE: [1666713]: BUILD STARTED

dali-automaton · 2020-09-30T22:00:33Z

CI MESSAGE: [1666713]: BUILD FAILED

dali-automaton · 2020-10-01T07:38:15Z

CI MESSAGE: [1668846]: BUILD STARTED

dali-automaton · 2020-10-01T10:44:07Z

CI MESSAGE: [1668846]: BUILD FAILED

dali-automaton · 2020-10-01T13:03:58Z

CI MESSAGE: [1668846]: BUILD PASSED

dali-automaton · 2020-10-01T18:13:33Z

CI MESSAGE: [1670025]: BUILD STARTED

dali-automaton · 2020-10-01T19:20:19Z

CI MESSAGE: [1670025]: BUILD FAILED

dali-automaton · 2020-10-01T22:04:17Z

CI MESSAGE: [1670833]: BUILD STARTED

dali-automaton · 2020-10-02T01:30:04Z

CI MESSAGE: [1670833]: BUILD FAILED

dali-automaton · 2020-10-02T08:26:48Z

CI MESSAGE: [1671885]: BUILD STARTED

dali-automaton · 2020-10-02T11:34:03Z

CI MESSAGE: [1671885]: BUILD FAILED

dali-automaton · 2020-10-02T12:42:41Z

CI MESSAGE: [1672273]: BUILD STARTED

dali-automaton · 2020-10-02T14:32:31Z

CI MESSAGE: [1672273]: BUILD FAILED

dali-automaton · 2020-10-02T15:28:07Z

CI MESSAGE: [1672559]: BUILD STARTED

dali-automaton · 2020-10-02T18:10:31Z

CI MESSAGE: [1672559]: BUILD FAILED

dali-automaton · 2020-10-02T20:12:35Z

CI MESSAGE: [1673199]: BUILD STARTED

dali-automaton · 2020-10-02T22:06:12Z

CI MESSAGE: [1673199]: BUILD FAILED

dali-automaton · 2020-10-05T21:48:48Z

CI MESSAGE: [1678053]: BUILD STARTED

dali-automaton · 2020-10-06T01:31:11Z

CI MESSAGE: [1678053]: BUILD FAILED

dali-automaton · 2020-10-11T19:00:20Z

CI MESSAGE: [1692667]: BUILD STARTED

dali-automaton · 2020-10-11T20:12:12Z

CI MESSAGE: [1692667]: BUILD FAILED

dali-automaton · 2020-10-13T01:06:01Z

CI MESSAGE: [1695978]: BUILD STARTED

dali-automaton · 2020-10-13T03:59:37Z

CI MESSAGE: [1695978]: BUILD FAILED

dali-automaton · 2020-10-13T11:38:30Z

CI MESSAGE: [1697321]: BUILD STARTED

dali-automaton · 2020-10-13T16:05:52Z

CI MESSAGE: [1697321]: BUILD FAILED

dali-automaton · 2020-10-14T09:51:07Z

CI MESSAGE: [1697321]: BUILD PASSED

jantonguirao · 2020-10-16T11:07:17Z

conda/recipe/build.sh

@@ -59,11 +59,17 @@ cmake -DCUDA_TOOLKIT_ROOT_DIR=/usr/local/cuda \
      -DCMAKE_INSTALL_PREFIX=$PREFIX                      \
      -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE:-Release}     \
      -DBUILD_TEST=${BUILD_TEST:-ON}                      \
+      -DBUILD_DALI_KERNELS=${BUILD_DALI_KERNELS:-ON}      \


those are not options exposed to CMake. We should remove those three from here. Remove BUILD_DALI_KERNELS BUILD_DALI_PIPELINE BUILD_DALI_OPERATORS

jantonguirao · 2020-10-16T11:08:56Z

docker/build.sh

@@ -136,11 +136,17 @@ if [ "$BUILD_INHOST" == "YES" ]; then
                                        CUDA_TARGET_ARCHS=\"${CUDA_TARGET_ARCHS}\"\
                                        CMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}      \
                                        BUILD_TEST=${BUILD_TEST}                  \
+                                        BUILD_DALI_KERNELS=${BUILD_DALI_KERNELS}  \


Remove BUILD_DALI_KERNELS BUILD_DALI_PIPELINE BUILD_DALI_OPERATORS

jantonguirao · 2020-10-16T11:09:05Z

docker/build.sh

@@ -169,10 +175,16 @@ else
                                   --build-arg "CMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}"      \
                                   --build-arg "BUILD_TEST=${BUILD_TEST}"                  \
                                   --build-arg "BUILD_BENCHMARK=${BUILD_BENCHMARK}"        \
+                                   --build-arg "BUILD_DALI_KERNELS=${BUILD_DALI_KERNELS}"  \


Remove BUILD_DALI_KERNELS BUILD_DALI_PIPELINE BUILD_DALI_OPERATORS

jantonguirao · 2020-10-16T11:09:14Z

docker/build_helper.sh

@@ -25,12 +25,18 @@ shift $((OPTIND - 1))
 export ARCH=${ARCH}
 export CMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE:-Release}
 export BUILD_TEST=${BUILD_TEST:-ON}
+export BUILD_DALI_KERNELS=${BUILD_DALI_KERNELS:-ON}


Remove BUILD_DALI_KERNELS BUILD_DALI_PIPELINE BUILD_DALI_OPERATORS

jantonguirao · 2020-10-16T11:09:22Z

docker/build_helper.sh

@@ -60,11 +68,17 @@ cmake ../ -DCMAKE_INSTALL_PREFIX=.                 \
      -DCUDA_TARGET_ARCHS=${CUDA_TARGET_ARCHS}     \
      -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}       \
      -DBUILD_TEST=${BUILD_TEST}                   \
+      -DBUILD_DALI_KERNELS=${BUILD_DALI_KERNELS}   \


Remove BUILD_DALI_KERNELS BUILD_DALI_PIPELINE BUILD_DALI_OPERATORS

jantonguirao · 2020-10-16T11:12:22Z

qa/TL0_python-self-test_xavier/test_body.sh

+        for exclude in "${EXCLUDE_PACKAGES[@]}"; do
+            grep -qiE ${exclude} ${test_script} && status=$((status+1))
+        done
+        # execute only when no machtes are found


Suggested change

# execute only when no machtes are found

# execute only when no matches are found

jantonguirao · 2020-10-16T11:14:01Z

dali/python/bundle-wheel.sh

@@ -44,6 +44,7 @@
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

 INWHL=$(readlink -e $1)
+PATH_PREFIX=${2:-local}


Suggested change

PATH_PREFIX=${2:-local}

PATH_PREFIX=${2:-/usr/local}

If it's a prefix it should be a prefix :)

Changed to DEPS_PATH

jantonguirao · 2020-10-16T11:14:11Z

dali/python/bundle-wheel.sh

-    "libopenjp2.so.7"
-    "libzstd.so.1"
-    "libz.so.1"
+    "/usr/${PATH_PREFIX}/lib64/libjpeg.so.62"


Suggested change

"/usr/${PATH_PREFIX}/lib64/libjpeg.so.62"

"${PATH_PREFIX}/lib64/libjpeg.so.62"

For jetson it is /usr/aarch64-linux-gnu/lib64/. I can change the name to DEPS_PATH.

jantonguirao · 2020-10-16T11:18:31Z

docker/build_helper.sh

 export BUILD_BENCHMARK=${BUILD_BENCHMARK:-ON}
 # use a default value as it differs for CUDA 9.x and CUDA 10.x
 export BUILD_NVTX=${BUILD_NVTX}
 export BUILD_PYTHON=${BUILD_PYTHON:-ON}
 export BUILD_LMDB=${BUILD_LMDB:-ON}
 export BUILD_JPEG_TURBO=${BUILD_JPEG_TURBO:-ON}
+export BUILD_FFMPEG=${BUILD_FFMPEG:-ON}


remove, BUILD_FFMPEG is an internal variable (BUILD_NVDEC is the exposed option)

jantonguirao · 2020-10-16T11:18:47Z

conda/recipe/build.sh

      -DBUILD_BENCHMARK=${BUILD_BENCHMARK:-ON}            \
      -DBUILD_NVTX=${BUILD_NVTX}                          \
      -DBUILD_PYTHON=${BUILD_PYTHON:-ON}                  \
      -DBUILD_LMDB=${BUILD_LMDB:-ON}                      \
      -DBUILD_JPEG_TURBO=${BUILD_JPEG_TURBO:-ON}          \
+      -DBUILD_FFMPEG=${BUILD_FFMPEG:-ON}                  \


remove, BUILD_FFMPEG is an internal variable (BUILD_NVDEC is the exposed option)

jantonguirao · 2020-10-16T11:19:51Z

docker/build.sh

                                   --build-arg "BUILD_NVTX=${BUILD_NVTX}"                  \
                                   --build-arg "BUILD_PYTHON=${BUILD_PYTHON}"              \
                                   --build-arg "BUILD_LMDB=${BUILD_LMDB}"                  \
                                   --build-arg "BUILD_JPEG_TURBO=${BUILD_JPEG_TURBO}"      \
+                                   --build-arg "BUILD_FFMPEG=${BUILD_FFMPEG}"              \


remove, BUILD_FFMPEG is an internal variable (BUILD_NVDEC is the exposed option)

- adds a way to build Python bindings when cross-compiling DALI for Xavier platform - adds a way to generate Python wheel for Xavier Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>

dali-automaton · 2020-10-16T11:50:37Z

CI MESSAGE: [1707811]: BUILD STARTED

jantonguirao · 2020-10-16T12:13:39Z

dali/python/bundle-wheel.sh

@@ -44,6 +44,7 @@
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

 INWHL=$(readlink -e $1)
+DEPS_PATH=${2:-local}


Suggested change

DEPS_PATH=${2:-local}

DEPS_PATH=${2:-/usr/local}

and adjust below

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>

dali-automaton · 2020-10-16T12:38:10Z

CI MESSAGE: [1707907]: BUILD STARTED

dali-automaton · 2020-10-16T15:06:56Z

CI MESSAGE: [1707907]: BUILD PASSED

JanuszL force-pushed the jetson_whl branch from 0a768d4 to d3c8965 Compare October 1, 2020 21:20

JanuszL force-pushed the jetson_whl branch from ceeb7f5 to 5b6f546 Compare October 2, 2020 15:19

JanuszL force-pushed the jetson_whl branch from 5b6f546 to e2e475a Compare October 2, 2020 18:41

JanuszL force-pushed the jetson_whl branch 3 times, most recently from 9756884 to f90917e Compare October 5, 2020 20:50

JanuszL force-pushed the jetson_whl branch 3 times, most recently from 6c159b1 to ec8fdea Compare October 6, 2020 09:15

klecki approved these changes Oct 12, 2020

View reviewed changes

JanuszL force-pushed the jetson_whl branch 2 times, most recently from 1f8ef05 to 9ef2c3d Compare October 13, 2020 01:04

JanuszL force-pushed the jetson_whl branch from 9ef2c3d to f4d3272 Compare October 13, 2020 07:29

jantonguirao reviewed Oct 16, 2020

View reviewed changes

JanuszL added 8 commits October 16, 2020 13:32

Add ability to cross-build Python wheels for Jetson

43a50c4

- adds a way to build Python bindings when cross-compiling DALI for Xavier platform - adds a way to generate Python wheel for Xavier Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>

Extend Xavier tests

ec79177

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>

Fix build

d7f22f8

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>

Python3.9

be7df0d

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>

Core review fixes

884b697

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>

TF support

3c93809

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>

Fix build

45095a3

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>

Code review fixes

db2a25b

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>

JanuszL force-pushed the jetson_whl branch from f4d3272 to db2a25b Compare October 16, 2020 11:43

jantonguirao reviewed Oct 16, 2020

View reviewed changes

More review fixes

d7b6565

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>

jantonguirao approved these changes Oct 16, 2020

View reviewed changes

JanuszL merged commit 97152cd into NVIDIA:master Oct 16, 2020

JanuszL deleted the jetson_whl branch October 16, 2020 15:35

	# execute only when no machtes are found
	# execute only when no matches are found

	"/usr/${PATH_PREFIX}/lib64/libjpeg.so.62"
	"${PATH_PREFIX}/lib64/libjpeg.so.62"

Add ability to cross-build Python wheels for Jetson #2313

Add ability to cross-build Python wheels for Jetson #2313

Conversation

JanuszL commented Sep 30, 2020 • edited Loading

Why we need this PR?

What happened in this PR?

dali-automaton commented Sep 30, 2020

dali-automaton commented Sep 30, 2020

dali-automaton commented Sep 30, 2020

dali-automaton commented Sep 30, 2020

dali-automaton commented Oct 1, 2020

dali-automaton commented Oct 1, 2020

dali-automaton commented Oct 1, 2020

dali-automaton commented Oct 1, 2020

dali-automaton commented Oct 1, 2020

dali-automaton commented Oct 1, 2020

dali-automaton commented Oct 2, 2020

dali-automaton commented Oct 2, 2020

dali-automaton commented Oct 2, 2020

dali-automaton commented Oct 2, 2020

dali-automaton commented Oct 2, 2020

dali-automaton commented Oct 2, 2020

dali-automaton commented Oct 2, 2020

dali-automaton commented Oct 2, 2020

dali-automaton commented Oct 2, 2020

dali-automaton commented Oct 5, 2020

dali-automaton commented Oct 6, 2020

dali-automaton commented Oct 11, 2020

dali-automaton commented Oct 11, 2020

dali-automaton commented Oct 13, 2020

dali-automaton commented Oct 13, 2020

dali-automaton commented Oct 13, 2020

dali-automaton commented Oct 13, 2020

dali-automaton commented Oct 14, 2020

jantonguirao Oct 16, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JanuszL Oct 16, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JanuszL Oct 16, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dali-automaton commented Oct 16, 2020

Choose a reason for hiding this comment

dali-automaton commented Oct 16, 2020

dali-automaton commented Oct 16, 2020

JanuszL commented Sep 30, 2020 •

edited

Loading

jantonguirao Oct 16, 2020 •

edited

Loading

JanuszL Oct 16, 2020 •

edited

Loading

JanuszL Oct 16, 2020 •

edited

Loading