Enable CUDA 11 compatibility mode #2356

JanuszL · 2020-10-14T09:29:32Z

makes CUDA 11.1 builds to be named as CUDA 11.0 because due to the CUDA enhanced compatibility of the build with the latest toolkit version will run on the latest CUDA 11.0 capable driver

Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com

Why we need this PR?

Pick one, remove the rest

It enables CUDA 11 compatibility mode

What happened in this PR?

Fill relevant points, put NA otherwise. Replace anything inside []

What solution was applied:
makes CUDA 11.1 builds to be named as CUDA 11.0 because due to the CUDA enhanced compatibility of the build with the latest toolkit version will run on the latest CUDA 11.0 capable driver
Affected modules and functionalities:
plain and conda build
Key points relevant for the review:
if it is the right way?
Validation and testing:
CI
Documentation (including examples):
compilation/installation instruction is updated

JIRA TASK: [NA]

dali-automaton · 2020-10-14T09:34:32Z

CI MESSAGE: [1700565]: BUILD STARTED

dali-automaton · 2020-10-14T10:56:01Z

CI MESSAGE: [1700749]: BUILD STARTED

dali-automaton · 2020-10-14T10:58:49Z

CI MESSAGE: [1700756]: BUILD STARTED

dali-automaton · 2020-10-14T11:49:13Z

CI MESSAGE: [1700756]: BUILD FAILED

dali-automaton · 2020-10-14T13:11:17Z

CI MESSAGE: [1700756]: BUILD PASSED

jantonguirao · 2020-10-15T17:40:05Z

cmake/Utils.cmake

  set(${CUDA_VERSION_SHORT_VAR} "${${CUDA_VERSION_MAJOR_VAR}}.${${CUDA_VERSION_MINOR_VAR}}" PARENT_SCOPE)
  set(${CUDA_VERSION_SHORT_DIGIT_ONLY_VAR} "${${CUDA_VERSION_MAJOR_VAR}}${${CUDA_VERSION_MINOR_VAR}}" PARENT_SCOPE)

-  message(STATUS "CUDA version: ${CUDA_VERSION}, major: ${${CUDA_VERSION_MAJOR_VAR}}, minor: ${${CUDA_VERSION_MINOR_VAR}}, patch: ${${CUDA_VERSION_PATCH_VAR}}, short: ${${CUDA_VERSION_SHORT_VAR}}, digit-only: ${${CUDA_VERSION_SHORT_DIGIT_ONLY_VAR}}")
+  message(STATUS "CUDA version compatibile: major: ${${CUDA_VERSION_MAJOR_VAR}}, minor: ${${CUDA_VERSION_MINOR_VAR}}, patch: ${${CUDA_VERSION_PATCH_VAR}}, short: ${${CUDA_VERSION_SHORT_VAR}}, digit-only: ${${CUDA_VERSION_SHORT_DIGIT_ONLY_VAR}}")


Suggested change

message(STATUS "CUDA version compatibile: major: ${${CUDA_VERSION_MAJOR_VAR}}, minor: ${${CUDA_VERSION_MINOR_VAR}}, patch: ${${CUDA_VERSION_PATCH_VAR}}, short: ${${CUDA_VERSION_SHORT_VAR}}, digit-only: ${${CUDA_VERSION_SHORT_DIGIT_ONLY_VAR}}")

message(STATUS "Compatible CUDA version: major: ${${CUDA_VERSION_MAJOR_VAR}}, minor: ${${CUDA_VERSION_MINOR_VAR}}, patch: ${${CUDA_VERSION_PATCH_VAR}}, short: ${${CUDA_VERSION_SHORT_VAR}}, digit-only: ${${CUDA_VERSION_SHORT_DIGIT_ONLY_VAR}}")

jantonguirao · 2020-10-15T17:41:40Z

docs/compilation.rst

-    ``.XX.Y`` can be passed, script check for the supported version is bypased and the user needs
-    to make sure that Dockerfile.cudaXXY.deps is present in `docker/` directory.
+  | The default is ``11.1``. Thanks to CUDA extended compatibility mode CUDA 11.1 wheel is named as
+    CUDA 11.0 because it can work with the CUDA 11.0 R450.x driver family (please update to the


Suggested change

CUDA 11.0 because it can work with the CUDA 11.0 R450.x driver family (please update to the

CUDA 11.0 because it can work with the CUDA 11.0 R450.x driver family. Please update to the

jantonguirao · 2020-10-15T17:41:50Z

docs/compilation.rst

-    to make sure that Dockerfile.cudaXXY.deps is present in `docker/` directory.
+  | The default is ``11.1``. Thanks to CUDA extended compatibility mode CUDA 11.1 wheel is named as
+    CUDA 11.0 because it can work with the CUDA 11.0 R450.x driver family (please update to the
+    latest recommended driver version in that family). If the value of the version is prefixed with


Suggested change

latest recommended driver version in that family). If the value of the version is prefixed with

latest recommended driver version in that family. If the value of the version is prefixed with

jantonguirao · 2020-10-15T17:42:30Z

docs/compilation.rst

+  | The default is ``11.1``. Thanks to CUDA extended compatibility mode CUDA 11.1 wheel is named as
+    CUDA 11.0 because it can work with the CUDA 11.0 R450.x driver family (please update to the
+    latest recommended driver version in that family). If the value of the version is prefixed with
+    `.` then any value ``.XX.Y`` can be passed, script check for the supported version is bypassed


Suggested change

`.` then any value ``.XX.Y`` can be passed, script check for the supported version is bypassed

`.` then any value ``.XX.Y`` can be passed, and in that case the supported version check is bypassed

jantonguirao · 2020-10-15T17:42:42Z

docs/compilation.rst

+    CUDA 11.0 because it can work with the CUDA 11.0 R450.x driver family (please update to the
+    latest recommended driver version in that family). If the value of the version is prefixed with
+    `.` then any value ``.XX.Y`` can be passed, script check for the supported version is bypassed
+    and the user needs to make sure that Dockerfile.cudaXXY.deps is present in `docker/` directory.


Suggested change

and the user needs to make sure that Dockerfile.cudaXXY.deps is present in `docker/` directory.

and the user needs to make sure that Dockerfile.cudaXXY.deps is present in the `docker/` directory.

jantonguirao · 2020-10-15T17:42:58Z

docs/installation.rst

-    additional functionalities.
+    CUDA 11.0 build uses CUDA toolkit enhanced compatibility. It is built with the latest CUDA 11.x
+    toolkit while it can run on the latest, stable CUDA 11.0 capable drivers (450.80 or later).
+    Using the newest driver (455.x for example) may enable additional functionalities.


Suggested change

Using the newest driver (455.x for example) may enable additional functionalities.

Using the newest driver (455.x, for example) may enable additional functionalities.

dali_tf_plugin/build_in_custom_op_docker.sh

awolant · 2020-10-16T09:34:36Z

docs/compilation.rst

+  | The default is ``11.1``. Thanks to CUDA extended compatibility mode CUDA 11.1 wheel is named as
+    CUDA 11.0 because it can work with the CUDA 11.0 R450.x driver family. Please update to the
+    latest recommended driver version in that family. If the value of the version is prefixed with
+    `.` then any value ``.XX.Y`` can be passed, and in that case the supported version check is


There is some issue with wording here, I think. the supported version check is and user ...

Done... I think

- makes CUDA 11.1 builds to be named as CUDA 11.0 because due to the CUDA enhanced compatibility of the build with the latest toolkit version will run on the latest CUDA 11.0 capable driver Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>

dali-automaton · 2020-10-16T09:45:44Z

CI MESSAGE: [1707617]: BUILD STARTED

mzient · 2020-10-16T10:49:38Z

docs/installation.rst

-    additional functionalities.
+    CUDA 11.0 build uses CUDA toolkit enhanced compatibility. It is built with the latest CUDA 11.x
+    toolkit while it can run on the latest, stable CUDA 11.0 capable drivers (450.80 or later).
+    Using the newest driver (455.x, for example) may enable additional functionalities.


I don't think that we need to put an "example" of latest driver - that's bound to go stale.

Suggested change

Using the newest driver (455.x, for example) may enable additional functionalities.

Using the latest driver may enable additional functionality.

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>

dali-automaton · 2020-10-16T11:12:17Z

CI MESSAGE: [1707770]: BUILD STARTED

dali-automaton · 2020-10-16T12:09:25Z

CI MESSAGE: [1707770]: BUILD FAILED

dali-automaton · 2020-10-16T12:34:27Z

CI MESSAGE: [1707896]: BUILD STARTED

dali-automaton · 2020-10-16T13:27:51Z

CI MESSAGE: [1707896]: BUILD FAILED

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>

dali-automaton · 2020-10-16T14:27:52Z

CI MESSAGE: [1708117]: BUILD STARTED

dali-automaton · 2020-10-16T17:08:52Z

CI MESSAGE: [1708117]: BUILD PASSED

awolant self-requested a review October 15, 2020 09:39

jantonguirao reviewed Oct 15, 2020

View reviewed changes

JanuszL force-pushed the cuda111_compatibility branch 3 times, most recently from f071a05 to ae2ce9c Compare October 16, 2020 08:29

jantonguirao approved these changes Oct 16, 2020

View reviewed changes

awolant approved these changes Oct 16, 2020

View reviewed changes

JanuszL added 3 commits October 16, 2020 11:39

Enable CUDA 11 compatibility mode

01f5180

- makes CUDA 11.1 builds to be named as CUDA 11.0 because due to the CUDA enhanced compatibility of the build with the latest toolkit version will run on the latest CUDA 11.0 capable driver Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>

Code review fixes

c099f6b

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>

More fixes

878b9f7

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>

JanuszL force-pushed the cuda111_compatibility branch from ae2ce9c to 878b9f7 Compare October 16, 2020 09:42

mzient reviewed Oct 16, 2020

View reviewed changes

More review fixes

58e12db

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>

mzient approved these changes Oct 16, 2020

View reviewed changes

Fix conda versioning

7eae512

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>

JanuszL force-pushed the cuda111_compatibility branch 3 times, most recently from edbc238 to 385b512 Compare October 16, 2020 12:32

Conda fix

730e638

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>

JanuszL force-pushed the cuda111_compatibility branch from 385b512 to 730e638 Compare October 16, 2020 13:44

JanuszL merged commit 2214987 into NVIDIA:master Oct 16, 2020

JanuszL deleted the cuda111_compatibility branch October 16, 2020 19:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable CUDA 11 compatibility mode #2356

Enable CUDA 11 compatibility mode #2356

JanuszL commented Oct 14, 2020

dali-automaton commented Oct 14, 2020

dali-automaton commented Oct 14, 2020

dali-automaton commented Oct 14, 2020

dali-automaton commented Oct 14, 2020

dali-automaton commented Oct 14, 2020

jantonguirao Oct 15, 2020

JanuszL Oct 16, 2020

jantonguirao Oct 15, 2020

JanuszL Oct 16, 2020

jantonguirao Oct 15, 2020

JanuszL Oct 16, 2020

jantonguirao Oct 15, 2020

JanuszL Oct 16, 2020

jantonguirao Oct 15, 2020

JanuszL Oct 16, 2020

jantonguirao Oct 15, 2020

JanuszL Oct 16, 2020

awolant Oct 16, 2020

JanuszL Oct 16, 2020

dali-automaton commented Oct 16, 2020

mzient Oct 16, 2020

JanuszL Oct 16, 2020

dali-automaton commented Oct 16, 2020

dali-automaton commented Oct 16, 2020

dali-automaton commented Oct 16, 2020

dali-automaton commented Oct 16, 2020

dali-automaton commented Oct 16, 2020

dali-automaton commented Oct 16, 2020

	message(STATUS "CUDA version compatibile: major: ${${CUDA_VERSION_MAJOR_VAR}}, minor: ${${CUDA_VERSION_MINOR_VAR}}, patch: ${${CUDA_VERSION_PATCH_VAR}}, short: ${${CUDA_VERSION_SHORT_VAR}}, digit-only: ${${CUDA_VERSION_SHORT_DIGIT_ONLY_VAR}}")
	message(STATUS "Compatible CUDA version: major: ${${CUDA_VERSION_MAJOR_VAR}}, minor: ${${CUDA_VERSION_MINOR_VAR}}, patch: ${${CUDA_VERSION_PATCH_VAR}}, short: ${${CUDA_VERSION_SHORT_VAR}}, digit-only: ${${CUDA_VERSION_SHORT_DIGIT_ONLY_VAR}}")

	CUDA 11.0 because it can work with the CUDA 11.0 R450.x driver family (please update to the
	CUDA 11.0 because it can work with the CUDA 11.0 R450.x driver family. Please update to the

	latest recommended driver version in that family). If the value of the version is prefixed with
	latest recommended driver version in that family. If the value of the version is prefixed with

	`.` then any value ``.XX.Y`` can be passed, script check for the supported version is bypassed
	`.` then any value ``.XX.Y`` can be passed, and in that case the supported version check is bypassed

	and the user needs to make sure that Dockerfile.cudaXXY.deps is present in `docker/` directory.
	and the user needs to make sure that Dockerfile.cudaXXY.deps is present in the `docker/` directory.

	Using the newest driver (455.x for example) may enable additional functionalities.
	Using the newest driver (455.x, for example) may enable additional functionalities.

	Using the newest driver (455.x, for example) may enable additional functionalities.
	Using the latest driver may enable additional functionality.

Enable CUDA 11 compatibility mode #2356

Enable CUDA 11 compatibility mode #2356

Conversation

JanuszL commented Oct 14, 2020

Why we need this PR?

What happened in this PR?

dali-automaton commented Oct 14, 2020

dali-automaton commented Oct 14, 2020

dali-automaton commented Oct 14, 2020

dali-automaton commented Oct 14, 2020

dali-automaton commented Oct 14, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dali-automaton commented Oct 16, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dali-automaton commented Oct 16, 2020

dali-automaton commented Oct 16, 2020

dali-automaton commented Oct 16, 2020

dali-automaton commented Oct 16, 2020

dali-automaton commented Oct 16, 2020

dali-automaton commented Oct 16, 2020