Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve shape of psuedoscalars in arithmetic ops. #2359

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

mzient
Copy link
Contributor

@mzient mzient commented Oct 14, 2020

Signed-off-by: Michał Zientkiewicz mzient@gmail.com

Why we need this PR?

Pick one, remove the rest

  • It fixes a bug: psuedoscalars "magically" converted to true scalars

What happened in this PR?

Fill relevant points, put NA otherwise. Replace anything inside []

  • What solution was applied:
    • Go through all inputs and choose either the shape of the non-scalar or highest dimensionality pseudoscalar
  • Affected modules and functionalities:
    • Arithmetic ops
  • Key points relevant for the review:
    • N/A
  • Validation and testing:
    • Added a test that checks that the psudoscalar shape i preserved
  • Documentation (including examples):
    • N/A

JIRA TASK: N/A

Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
@mzient mzient requested a review from a team October 14, 2020 13:57
@mzient
Copy link
Contributor Author

mzient commented Oct 14, 2020

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1701148]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1701148]: BUILD PASSED

@mzient mzient merged commit 7184ffa into NVIDIA:master Oct 14, 2020
@mzient mzient deleted the FixArithmOpScalars branch October 14, 2020 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants