-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mask processing to COCO Reader with Augmentations example #2426
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
3702634
to
3869102
Compare
View / edit / reply to this conversation on ReviewNB banasraf commented on 2020-11-03T09:45:27Z We will start... Later you write "We can now run the pipeline". Not sure if it's inconsistency in the tense. Anyway, I personally prefer present tense in the examples but I guess both are ok if it's consistent. |
View / edit / reply to this conversation on ReviewNB banasraf commented on 2020-11-03T09:45:27Z have to been -> have to be |
View / edit / reply to this conversation on ReviewNB banasraf commented on 2020-11-03T09:45:28Z If necessary, we could clamp the coordinates If necessary, clamp the coordinates ?
Comments describing the operators also could be more consistent. There's "Converting bounding boxes..." and "Adjust masks coordinates...". I would go for imperative but gerund is also ok, I think.
|
View / edit / reply to this conversation on ReviewNB JanuszL commented on 2020-11-03T18:02:39Z Do we need "# Using DALI's functional style API" comment? |
View / edit / reply to this conversation on ReviewNB JanuszL commented on 2020-11-03T18:02:40Z Wrapping the pipeline definition in separate functions that we can reuse it later -> # Wrapping the pipeline definition in separate functions that we can reuse later |
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
004a50d
to
34db1cc
Compare
Signed-off-by: Joaquin Anton <janton@nvidia.com>
34db1cc
to
40d0b15
Compare
!build |
CI MESSAGE: [1765255]: BUILD STARTED |
CI MESSAGE: [1765255]: BUILD PASSED |
Signed-off-by: Joaquin Anton janton@nvidia.com
Why we need this PR?
Pick one, remove the rest
What happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
Added mask polygon processing to the example
COCO Reader with Augmentations example
All
N/A
N/A
JIRA TASK: [Use DALI-XXXX or NA]