Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mask processing to COCO Reader with Augmentations example #2426

Merged
merged 4 commits into from
Nov 5, 2020

Conversation

jantonguirao
Copy link
Contributor

Signed-off-by: Joaquin Anton janton@nvidia.com

Why we need this PR?

Pick one, remove the rest

  • It enhances the "COCO Reader with Augmentations" example, demonstrating mask polygon processing

What happened in this PR?

Fill relevant points, put NA otherwise. Replace anything inside []

  • What solution was applied:
    Added mask polygon processing to the example
  • Affected modules and functionalities:
    COCO Reader with Augmentations example
  • Key points relevant for the review:
    All
  • Validation and testing:
    N/A
  • Documentation (including examples):
    N/A

JIRA TASK: [Use DALI-XXXX or NA]

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@review-notebook-app
Copy link

View / edit / reply to this conversation on ReviewNB

banasraf commented on 2020-11-03T09:45:27Z
----------------------------------------------------------------

We will start...

Later you write "We can now run the pipeline". Not sure if it's inconsistency in the tense. Anyway, I personally prefer present tense in the examples but I guess both are ok if it's consistent.


@review-notebook-app
Copy link

View / edit / reply to this conversation on ReviewNB

banasraf commented on 2020-11-03T09:45:27Z
----------------------------------------------------------------

have to been -> have to be


@review-notebook-app
Copy link

View / edit / reply to this conversation on ReviewNB

banasraf commented on 2020-11-03T09:45:28Z
----------------------------------------------------------------

If necessary, we could clamp the coordinates

If necessary, clamp the coordinates ?

Comments describing the operators also could be more consistent. There's "Converting bounding boxes..." and "Adjust masks coordinates...". I would go for imperative but gerund is also ok, I think.

relative to absolute coordinates by mapping the top-l comment lacks indentation


@review-notebook-app
Copy link

View / edit / reply to this conversation on ReviewNB

JanuszL commented on 2020-11-03T18:02:39Z
----------------------------------------------------------------

Do we need "# Using DALI's functional style API" comment?


@review-notebook-app
Copy link

View / edit / reply to this conversation on ReviewNB

JanuszL commented on 2020-11-03T18:02:40Z
----------------------------------------------------------------

Wrapping the pipeline definition in separate functions that we can reuse it later

->

# Wrapping the pipeline definition in separate functions that we can reuse later


Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
@jantonguirao
Copy link
Contributor Author

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1765255]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1765255]: BUILD PASSED

@jantonguirao jantonguirao merged commit 33118aa into NVIDIA:master Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants