Make the custom nvJPEG allocator not throw and return only the status #2443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
!build |
|
CI MESSAGE: [1770676]: BUILD STARTED |
|
CI MESSAGE: [1770676]: BUILD PASSED |
awolant
approved these changes
Nov 9, 2020
mzient
reviewed
Nov 9, 2020
Comment on lines
215
to
217
| } catch (...) { | ||
| *ptr = nullptr; | ||
| return cudaErrorMemoryAllocation; |
There was a problem hiding this comment.
I don't think we should at least try to return a meaningful status
Suggested change
| } catch (...) { | |
| *ptr = nullptr; | |
| return cudaErrorMemoryAllocation; | |
| } catch (const CUDABadAlloc &) { | |
| *ptr = nullptr; | |
| return cudaErrorMemoryAllocation; | |
| } catch (const CUDAError &e) { | |
| *ptr = nullptr; | |
| return e.is_rt_api() ? e.rt_error() : cudaErrorUnknown; | |
| } catch (const std::exception &e) { | |
| // print? should we catch it at all? | |
| *ptr = nullptr; | |
| return cudaErrorUnknown; | |
| } catch (...) { | |
| // Now that's really heavy stuff - print something? | |
| // Should we really catch it? | |
| *ptr = nullptr; | |
| return cudaErrorUnknown; | |
| } |
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
!build |
|
CI MESSAGE: [1775029]: BUILD STARTED |
mzient
approved these changes
Nov 9, 2020
|
CI MESSAGE: [1775029]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com
Why we need this PR?
Pick one, remove the rest
What happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
make the custom nvJPEG allocator not throw and return only the status
nvJPEG based decoder
NA
CI
NA
JIRA TASK: [Use DALI-1721]