Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skips the building of prebuilt DALI package for nvidia-tensorflow #2451

Merged
merged 2 commits into from Nov 13, 2020

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Nov 10, 2020

  • building of DALI TF plugin for nvidia-0tesnorflow doesn't work in the tensorflow/tensorflow:custom-op-gpu-ubuntu16 as nvidia-tensorflow requires Ubuntu 18.04 or newer so skip it in the build.sh user build
  • when the nvidia-tensorflow can be installed DALI plugin can be usually installed on the fly after that as well as Ubuntu 18.04 is the system used to build it

Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com

Why we need this PR?

Pick one, remove the rest

  • It skips the building of prebuild DALI package for nvidia-tensorflow

What happened in this PR?

Fill relevant points, put NA otherwise. Replace anything inside []

  • What solution was applied:
    building of DALI TF plugin for nvidia-0tesnorflow doesn't work in the tensorflow/tensorflow:custom-op-gpu-ubuntu16 as nvidia-tensorflow requires Ubuntu 18.04 or newer so skip it in the build.sh user build
  • Affected modules and functionalities:
    user manual build
  • Key points relevant for the review:
    NA
  • Validation and testing:
    manual build REBUILD_BUILDERS=YES CUDA_VERSION=11.0 BUILD_TF_PLUGIN=YES CREATE_RUNNER=YES ./build.sh
  • Documentation (including examples):
    NA

Relates to #2448 and #2449
JIRA TASK: [NA]

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1785566]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1785566]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1792133]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1792133]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1792837]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1792837]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1792837]: BUILD PASSED

- building of DALI TF plugin for nvidia-0tesnorflow doesn't work in
  the tensorflow/tensorflow:custom-op-gpu-ubuntu16 as nvidia-tensorflow
  requires Ubuntu 18.04 or newer so skip it in the build.sh user build
- when the nvidia-tensorflow can be installed DALI plugin can be usually
  installed on the fly after that as well as Ubuntu 18.04 is the system
  used to build it

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1793447]: BUILD STARTED

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1793607]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1793607]: BUILD PASSED

@mzient mzient changed the title Skips the building of prebuild DALI package for nvidia-tensorflow Skips the building of prebuilt DALI package for nvidia-tensorflow Nov 13, 2020
@JanuszL JanuszL merged commit 03be56c into NVIDIA:master Nov 13, 2020
@JanuszL JanuszL deleted the skip_nv_tf_build branch November 13, 2020 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants