-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support the output layouts in the PythonFunction Operator #2486
Merged
banasraf
merged 3 commits into
NVIDIA:master
from
banasraf:support-layout-in-python-function
Nov 24, 2020
Merged
Support the output layouts in the PythonFunction Operator #2486
banasraf
merged 3 commits into
NVIDIA:master
from
banasraf:support-layout-in-python-function
Nov 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rafal <Banas.Rafal97@gmail.com>
!build |
CI MESSAGE: [1818252]: BUILD STARTED |
CI MESSAGE: [1818252]: BUILD FAILED |
klecki
reviewed
Nov 20, 2020
JanuszL
reviewed
Nov 23, 2020
JanuszL
reviewed
Nov 23, 2020
JanuszL
reviewed
Nov 23, 2020
When it is merged can you go through issue/s and tell the people that this PR should address their use cases. |
!build |
CI MESSAGE: [1827756]: BUILD STARTED |
JanuszL
reviewed
Nov 24, 2020
JanuszL
reviewed
Nov 24, 2020
b25c907
to
822a2df
Compare
JanuszL
approved these changes
Nov 24, 2020
CI MESSAGE: [1827756]: BUILD FAILED |
Signed-off-by: Rafal <Banas.Rafal97@gmail.com>
822a2df
to
553d86b
Compare
klecki
reviewed
Nov 24, 2020
klecki
approved these changes
Nov 24, 2020
!build |
CI MESSAGE: [1828681]: BUILD STARTED |
CI MESSAGE: [1828681]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why we need this PR?
What happened in this PR?
An additional argument was added.
DLTesnorPythonFunctionImpl implementation
Chagnes in the DLTensorPythonFunctrionImpl
New tests in test_operator_python_function.py.
I've documented the added argument.
JIRA TASK: DALI-1685