Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the output layouts in the PythonFunction Operator #2486

Merged
merged 3 commits into from
Nov 24, 2020

Conversation

banasraf
Copy link
Collaborator

Why we need this PR?

  • It adds a way to specify the output layouts in the PythonFunction needed because of multiple users requests.

What happened in this PR?

  • What solution was applied:
    An additional argument was added.
  • Affected modules and functionalities:
    DLTesnorPythonFunctionImpl implementation
  • Key points relevant for the review:
    Chagnes in the DLTensorPythonFunctrionImpl
  • Validation and testing:
    New tests in test_operator_python_function.py.
  • Documentation (including examples):
    I've documented the added argument.

JIRA TASK: DALI-1685

Signed-off-by: Rafal <Banas.Rafal97@gmail.com>
Signed-off-by: Rafal <Banas.Rafal97@gmail.com>
@banasraf
Copy link
Collaborator Author

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1818252]: BUILD STARTED

@banasraf banasraf requested a review from a team November 20, 2020 14:02
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1818252]: BUILD FAILED

@JanuszL
Copy link
Contributor

JanuszL commented Nov 23, 2020

When it is merged can you go through issue/s and tell the people that this PR should address their use cases.

@banasraf
Copy link
Collaborator Author

@JanuszL @klecki
I've changed the behavior of the argument to match the one in ExternalSource:

  • when a single string is passed, all of the outputs get the same layout
  • the list can be shorter than the number of outputs

@banasraf
Copy link
Collaborator Author

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1827756]: BUILD STARTED

@banasraf banasraf force-pushed the support-layout-in-python-function branch from b25c907 to 822a2df Compare November 24, 2020 09:26
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1827756]: BUILD FAILED

Signed-off-by: Rafal <Banas.Rafal97@gmail.com>
@banasraf banasraf force-pushed the support-layout-in-python-function branch from 822a2df to 553d86b Compare November 24, 2020 10:34
@banasraf
Copy link
Collaborator Author

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1828681]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1828681]: BUILD PASSED

@banasraf banasraf merged commit bba5261 into NVIDIA:master Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants