Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable nvJPEG2000 #2501

Merged
merged 3 commits into from
Nov 27, 2020
Merged

Reenable nvJPEG2000 #2501

merged 3 commits into from
Nov 27, 2020

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Nov 27, 2020

Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com

Why we need this PR?

Pick one, remove the rest

  • It reenables nvJPEG2000

What happened in this PR?

Fill relevant points, put NA otherwise. Replace anything inside []

  • What solution was applied:
    updates nvJPEG2000 version in the dependencies
    switch nvJPEG2000 support to be on by default
  • Affected modules and functionalities:
    build system
    deps docker image
  • Key points relevant for the review:
    NA
  • Validation and testing:
    CI - current tests applies
  • Documentation (including examples):
    NA

JIRA TASK: [NA]

@JanuszL
Copy link
Contributor Author

JanuszL commented Nov 27, 2020

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1838621]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1838658]: BUILD STARTED

@awolant awolant assigned awolant and banasraf and unassigned banasraf and awolant Nov 27, 2020
@banasraf banasraf self-assigned this Nov 27, 2020
@awolant awolant requested review from a team and removed request for a team November 27, 2020 11:31
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1838621]: BUILD FAILED

@@ -9,7 +9,8 @@ RUN curl -LO https://developer.download.nvidia.com/compute/cuda/11.1.1/local_ins
./cuda_*.run --silent --no-opengl-libs --toolkit && \
rm -f cuda_*.run;

RUN apt-get update && \
RUN CUDA_VERSION=0.1.0 && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need this? Looks weird.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because docker caches its content based on the Dockerfile commands. So if the installation command is the same even if the underlying package is updated in the server docker build command will use the cached layer. Now, whenever we want to update nvJPEG2000 installation we will change this value and ask the docker to reinstall the necessary package.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we name it NVJPEG2K_VERSION? I presume, it's that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. Fixed.

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1838621]: BUILD PASSED

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1839252]: BUILD STARTED

@banasraf banasraf self-assigned this Nov 27, 2020
@banasraf
Copy link
Collaborator

The preprocessor def BUILD_NVJPEG2K_ENABLED doesn't work. If I remember correctly it needs to be changed to NVJPEG2K_ENABLED

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@JanuszL
Copy link
Contributor Author

JanuszL commented Nov 27, 2020

The preprocessor def BUILD_NVJPEG2K_ENABLED doesn't work. If I remember correctly it needs to be changed to NVJPEG2K_ENABLED

Done

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1839295]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1838658]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1839295]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1839295]: BUILD PASSED

@JanuszL JanuszL merged commit ba4f220 into NVIDIA:master Nov 27, 2020
@JanuszL JanuszL deleted the reenable_nvjpeg2000 branch November 27, 2020 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants