-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reenable nvJPEG2000 #2501
Reenable nvJPEG2000 #2501
Conversation
!build |
CI MESSAGE: [1838621]: BUILD STARTED |
CI MESSAGE: [1838658]: BUILD STARTED |
CI MESSAGE: [1838621]: BUILD FAILED |
@@ -9,7 +9,8 @@ RUN curl -LO https://developer.download.nvidia.com/compute/cuda/11.1.1/local_ins | |||
./cuda_*.run --silent --no-opengl-libs --toolkit && \ | |||
rm -f cuda_*.run; | |||
|
|||
RUN apt-get update && \ | |||
RUN CUDA_VERSION=0.1.0 && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need this? Looks weird.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because docker caches its content based on the Dockerfile commands. So if the installation command is the same even if the underlying package is updated in the server docker build command will use the cached layer. Now, whenever we want to update nvJPEG2000 installation we will change this value and ask the docker to reinstall the necessary package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we name it NVJPEG2K_VERSION? I presume, it's that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad. Fixed.
CI MESSAGE: [1838621]: BUILD PASSED |
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
3878ac9
to
1b16084
Compare
CI MESSAGE: [1839252]: BUILD STARTED |
The preprocessor def |
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Done |
CI MESSAGE: [1839295]: BUILD STARTED |
CI MESSAGE: [1838658]: BUILD FAILED |
CI MESSAGE: [1839295]: BUILD FAILED |
CI MESSAGE: [1839295]: BUILD PASSED |
Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com
Why we need this PR?
Pick one, remove the rest
What happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
updates nvJPEG2000 version in the dependencies
switch nvJPEG2000 support to be on by default
build system
deps docker image
NA
CI - current tests applies
NA
JIRA TASK: [NA]