Support for nvJPEG preallocate API for batched HW decoder #2544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!build |
|
CI MESSAGE: [1895377]: BUILD STARTED |
|
CI MESSAGE: [1895377]: BUILD FAILED |
|
CI MESSAGE: [1895383]: BUILD STARTED |
|
CI MESSAGE: [1895383]: BUILD FAILED |
JanuszL
force-pushed
the
use_memory_pool_hw
branch
from
21415d8
to
f7dc868
Compare
|
CI MESSAGE: [1899975]: BUILD STARTED |
|
CI MESSAGE: [1899977]: BUILD STARTED |
|
CI MESSAGE: [1899975]: BUILD PASSED |
|
CI MESSAGE: [1899977]: BUILD PASSED |
| NVJPEG_CALL(nvjpegDecodeBatchedPreAllocate( | ||
| handle_, | ||
| state_hw_batched_, | ||
| hw_decoder_bs_, |
There was a problem hiding this comment.
this might collide with the ongoing variable batch size changes. Maybe check with @szalpal
There was a problem hiding this comment.
Synced offline. Should be fine.
| .AddOptionalArg("preallocate_width_hint", | ||
| R"code(Applies **only** to the ``mixed`` backend type. | ||
|
|
||
| Hint about the expected maximum width of the processed images. It helps to allocate ahead of time |
There was a problem hiding this comment.
Image width hint.
The hint is used to preallocate memory for the HW JPEG decoder in NVIDIA Ampere GPU architecture.
maybe? (same for height)
jantonguirao
approved these changes
Dec 14, 2020
Signed-off-by: Albert Wolant <awolant@nvidia.com>
JanuszL
force-pushed
the
use_memory_pool_hw
branch
from
500c02d
to
3d89f34
Compare
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
JanuszL
force-pushed
the
use_memory_pool_hw
branch
from
e88778c
to
a6f768d
Compare
jantonguirao
approved these changes
Dec 14, 2020
|
!build |
|
CI MESSAGE: [1900628]: BUILD STARTED |
|
CI MESSAGE: [1900628]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Albert Wolant awolant@nvidia.com
Why we need this PR?
Pick one, remove the rest
What happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
adds support for nvJPEG preallocate API for batched HW decoder
ImageDecoder
NA
CI
Operator docs are updated
JIRA TASK: [DALI-1443]