Remove redundant JPEG decoder initialization from peeking shape function #2610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- in the case of progressive JPEG decoder initialization is very expensive and not needed for image shape inference Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
!build |
|
CI MESSAGE: [1975574]: BUILD STARTED |
|
CI MESSAGE: [1975574]: BUILD PASSED |
klecki
approved these changes
Jan 13, 2021
jantonguirao
approved these changes
Jan 14, 2021
| @@ -593,10 +593,9 @@ bool GetImageInfo(const void* srcdata, int datasize, int* width, int* height, | |||
| SetSrc(&cinfo, srcdata, datasize, false); | |||
|
|
|||
| DALI_ENFORCE(jpeg_read_header(&cinfo, TRUE) == JPEG_HEADER_OK); | |||
| DALI_ENFORCE(jpeg_start_decompress(&cinfo)); // required to transfer image size to cinfo | |||
There was a problem hiding this comment.
the original code says that this is required to transfer the image size to cinfo. Are we sure it is not needed?
There was a problem hiding this comment.
It was required to populate output_width, output_height and output_components, but is not needed for image_width, image_height and num_components. (Operator tests still passes).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com
Why we need this PR?
Pick one, remove the rest
What happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
Removes redundant JPEG decoder initialization from peeking shape function as in the case of progressive JPEG decoder initialization is very expensive and not needed for image shape inference
PeekImageShape operator
NA
present test applies
NA
JIRA TASK: [NA]