Fix a double set of preserve schema arg and uninitialized var
#2632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!build |
- when the user specifies the `preserve` operator argument it is set twice due to logic in ops.py. This PR makes sure it is set only once - 0 initializes next_seek_pos_ variable in the index_file_loader Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
JanuszL
force-pushed
the
fix_small_bugs
branch
from
1e776cb
to
ee620b2
Compare
|
CI MESSAGE: [2008098]: BUILD STARTED |
|
CI MESSAGE: [2008098]: BUILD PASSED |
mzient
approved these changes
Jan 25, 2021
jantonguirao
approved these changes
Jan 25, 2021
| out = dali.fn.external_source(source=[[np.array([-0.5, 1.25])]], preserve = True) | ||
| res = dali.fn.resize(out, preserve = True) | ||
| pipe.set_outputs(out) | ||
| pipe.build() |
There was a problem hiding this comment.
you don't run any iteration?
There was a problem hiding this comment.
It checks if build succeeds and args are properly consumed.
Co-authored-by: Joaquin Anton <j.anton.guirao@gmail.com>
|
!build |
|
CI MESSAGE: [2012390]: BUILD STARTED |
|
CI MESSAGE: [2012390]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preserveoperator argument it is set twice due to logic in ops.py. This PR makes sure it is set only onceSigned-off-by: Janusz Lisiecki jlisiecki@nvidia.com
Why we need this PR?
Pick one, remove the rest
preserveschema arg and uninitialized varWhat happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
makes sure
preserveschema arg is set only once0 initializes next_seek_pos_ variable in the index_file_loader
ops.py
index_file_loader
NA
test added
valgrind run
NA
JIRA TASK: [NA]