Fix variable batch size for list of tensors. Make Constant op constant again #2637
Conversation
…again. Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
|
!build |
| @@ -162,3 +163,23 @@ def test_constant_fn(): | |||
| def test_scalar_constant_promotion(): | |||
| yield _test_scalar_constant_promotion, "cpu" | |||
| yield _test_scalar_constant_promotion, "gpu" | |||
|
|
|||
There was a problem hiding this comment.
Maybe this should go to test_dali_variable_batch_size.py?
There was a problem hiding this comment.
It's just my opinion, but I don't like the whole idea of test_dali_variable_batch_size - it's a bag of very shallow tests. When we have variable batch size support across the board, we might just use variable batch size for new tests for other ops.
There was a problem hiding this comment.
So do we want to extend every operator's test to cover batch size variability more thoroughly?
There was a problem hiding this comment.
When it doesn't require jumping though too many hoops, then yes. Currently any test that uses readers is not exactly easily convertible to variable batch size.
|
CI MESSAGE: [2015851]: BUILD STARTED |
|
CI MESSAGE: [2015851]: BUILD PASSED |
Signed-off-by: Michał Zientkiewicz mzient@gmail.com
Why we need this PR?
Pick one, remove the rest
What happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
== p->batch_size()to<= p->max_batch_size()JIRA TASK: N/A