Expose names of Pipeline outputs in C API #2665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: szalpal <mszolucha@nvidia.com>
|
!build |
|
CI MESSAGE: [2058116]: BUILD STARTED |
Signed-off-by: szalpal <mszolucha@nvidia.com>
|
!build |
|
CI MESSAGE: [2058174]: BUILD STARTED |
mzient
reviewed
Feb 9, 2021
dali/c_api/c_api_test.cc
Outdated
| @@ -97,7 +98,7 @@ std::unique_ptr<Pipeline> GetTestPipeline(bool is_file_reader, const std::string | |||
| .AddInput(input_name, exec_device) | |||
| .AddOutput("outputs", exec_device)); | |||
There was a problem hiding this comment.
Suggested change
| .AddOutput("outputs", exec_device)); | |
| .AddOutput(output_name, exec_device)); |
mzient
approved these changes
Feb 9, 2021
JanuszL
reviewed
Feb 9, 2021
include/dali/c_api.h
Outdated
| @@ -335,6 +335,11 @@ DLL_PUBLIC size_t daliMaxDimTensors(daliPipelineHandle *pipe_handle, int n); | |||
| */ | |||
| DLL_PUBLIC unsigned daliGetNumOutput(daliPipelineHandle *pipe_handle); | |||
|
|
|||
| /** | |||
| * @brief Returns a string indicating name of the output given by id | |||
There was a problem hiding this comment.
Does it make sense to mention that the returned pointer is valid as long as the pipeline exists?
JanuszL
reviewed
Feb 9, 2021
dali/c_api/c_api_test.cc
Outdated
| device_id, false, prefetch_queue_depth, prefetch_queue_depth, | ||
| prefetch_queue_depth, false); | ||
|
|
||
| ASSERT_EQ(daliGetNumOutput(&handle), 1); |
There was a problem hiding this comment.
Maybe it would be better to check more than one output in this test.
JanuszL
approved these changes
Feb 9, 2021
|
CI MESSAGE: [2058174]: BUILD PASSED |
|
!build |
|
CI MESSAGE: [2062493]: BUILD STARTED |
JanuszL
approved these changes
Feb 10, 2021
|
CI MESSAGE: [2062493]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: szalpal mszolucha@nvidia.com
Why we need this PR?
Pick one, remove the rest
dali_backendWhat happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
augment C API
C API,
PipelineclassNA
Yes
Yes
JIRA TASK: [Use DALI-XXXX or NA]