Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that OpenCV decoding fallback follows EXIF information handling #2666

Merged
merged 1 commit into from Feb 10, 2021

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Feb 9, 2021

  • nvJPEG and libjpeg-turbo image decoding don't apply image rotation based on EXIF metadata. This PR makes sure that OpenCV fallback does the same to have a consistent behavior

Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com

Why we need this PR?

Pick one, remove the rest

  • Makes sure that OpenCV decoding fallback follows EXIF information handling

What happened in this PR?

Fill relevant points, put NA otherwise. Replace anything inside []

  • What solution was applied:
    nvJPEG and libjpeg-turbo image decoding don't apply image rotation based on EXIF metadata. This PR makes sure that OpenCV fallback does the same to have a consistent behavior
  • Affected modules and functionalities:
    generic_image
  • Key points relevant for the review:
    NA
  • Validation and testing:
    current tests apply
  • Documentation (including examples):
    Docs updated

JIRA TASK: [NA]

@JanuszL
Copy link
Contributor Author

JanuszL commented Feb 9, 2021

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2058848]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2058848]: BUILD PASSED

…ling

- nvJPEG and libjpeg-turbo image decoding don't apply image rotation based
  on EXIF metadata. This PR makes sure that OpenCV fallback does the same
  to have a consistent behavior

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@JanuszL
Copy link
Contributor Author

JanuszL commented Feb 9, 2021

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2059545]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2059545]: BUILD PASSED

@jantonguirao jantonguirao self-assigned this Feb 10, 2021
@JanuszL JanuszL merged commit 421bbd7 into NVIDIA:master Feb 10, 2021
@JanuszL JanuszL deleted the disregard_exif_orientation branch February 10, 2021 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants