Improvements in Dockerfile.deps for better reusability in a non-docker environment #2686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n a non-docker environment Signed-off-by: Joaquin Anton <janton@nvidia.com>
JanuszL
reviewed
Feb 17, 2021
Comment on lines
+58
to
+59
| make -j"$(grep ^processor /proc/cpuinfo | wc -l)" 2>&1 > /dev/null && \ | ||
| make install 2>&1 > /dev/null && \ |
There was a problem hiding this comment.
I see the value of moving to tmp, but why split build and install stages?
There was a problem hiding this comment.
As a user I wouldn't like to build as sudo, because all the generated files will be owned by root. I think it is cleaner to first build and then install as sudo.
JanuszL
approved these changes
Feb 17, 2021
banasraf
approved these changes
Feb 17, 2021
|
CI MESSAGE: [2085599]: BUILD STARTED |
|
CI MESSAGE: [2085599]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joaquin Anton janton@nvidia.com
Why we need this PR?
Pick one, remove the rest
When setting a new bare metal development environment, we typically refer to Dockerfile.deps and copy RUN commands that
download, build and install some dependencies. Some of those snippets work directly on the root directory and assume root privileges. We typically have to manually modify the snippets so that they are suitable for a bare-metal non-root user environment.
What happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
Work on
/tmpinstead of/Separate
makefrommake installcommands so that the user can easily addsudoto the latter only.Dockerfile.deps
Dockerfile.deps
Tested locally
NA
JIRA TASK: [Use DALI-XXXX or NA]