Add break of VideoReader loop when keyframe past requested has been reached #2706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eached - adds a frame reading loop break when a keyframe following the end of the last requested frame in the sequence Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
!build |
|
CI MESSAGE: [2098994]: BUILD STARTED |
|
CI MESSAGE: [2098994]: BUILD PASSED |
jantonguirao
changed the title
| if (!is_first_frame) { | ||
| nonkey_frame_count = 0; | ||
| if (frame > req.frame + req.count) { |
There was a problem hiding this comment.
Add a comment here. How about?
// Found a key frame past the requested range. We can stop searching (If there were missing frames in the range they won't be found after the next key frame)
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
awolant
approved these changes
Feb 23, 2021
|
!build |
|
CI MESSAGE: [2101801]: BUILD STARTED |
|
CI MESSAGE: [2101801]: BUILD PASSED |
jantonguirao
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com
Why we need this PR?
Pick one, remove the rest
What happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
adds a frame reading loop break when a keyframe following the end of the last requested frame in the sequence
video_loader
NA
current test applies
NA
JIRA TASK: [NA]