Expose all pipeline constructor arguments as properties. #2757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!build |
|
CI MESSAGE: [2132237]: BUILD STARTED |
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
|
!build |
|
CI MESSAGE: [2132249]: BUILD STARTED |
JanuszL
reviewed
Mar 4, 2021
| def test_properties(): | ||
| @dali.pipeline_def(batch_size=11, prefetch_queue_depth={"cpu_size":3, "gpu_size":2}) | ||
| def my_pipe(): | ||
| pipe = Pipeline.current() |
There was a problem hiding this comment.
Do we advertise Pipeline.current() anywhere?
There was a problem hiding this comment.
It's not documented very well - I don't know if it should in this PR or we should elaborate on it in some doc/tutorial.
There was a problem hiding this comment.
Maybe in getting started?
@awolant ?
|
CI MESSAGE: [2132249]: BUILD PASSED |
jantonguirao
reviewed
Mar 4, 2021
|
|
||
| @property | ||
| def seed(self): | ||
| """Random seed used in the pipeline or None, if seed is not fixed.""" |
There was a problem hiding this comment.
You are not checking if seed is not fixed(?)
There was a problem hiding this comment.
I removed replacement of None with -1 in the constructor. Now it's done when passing the seed to the native pipeline.
JanuszL
approved these changes
Mar 4, 2021
jantonguirao
approved these changes
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michał Zientkiewicz mzient@gmail.com
Why we need this PR?
Pick one, remove the rest
What happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
JIRA TASK: DALI-1897