Adjust the filenames of decoder test files and update licenses #2844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make them follow the same naming as readers. Add missing license Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
JanuszL
approved these changes
Apr 6, 2021
|
!build |
|
CI MESSAGE: [2240374]: BUILD STARTED |
|
CI MESSAGE: [2240374]: BUILD PASSED |
szalpal
approved these changes
Apr 7, 2021
| @@ -1,3 +1,17 @@ | |||
| # Copyright (c) 2020, NVIDIA CORPORATION. All rights reserved. | |||
There was a problem hiding this comment.
Technicaly, you do edit this file, so this should be 2020-2021, right? ;)
There was a problem hiding this comment.
Technically yes, but I just took the scope of the edits before adding this.
| @@ -38,7 +52,7 @@ def check_roi_random_crop(ndim=2, max_batch_size=16, | |||
| in_shape = dali.fn.shapes(shape_like_in, dtype=types.INT32) | |||
|
|
|||
| crop_shape = [(crop_min_extent + crop_max_extent) // 2] * ndim if random.choice([True, False]) \ | |||
| else fn.random.uniform(range=(crop_min_extent, crop_max_extent + 1), | |||
| else fn.random.uniform(range=(crop_min_extent, crop_max_extent + 1), | |||
There was a problem hiding this comment.
please trim the whitespaces after else
There was a problem hiding this comment.
Oh, there is double space. I don't want to rerun CI and this will touch the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make them follow the same naming as readers.
Add missing license in several files.
Signed-off-by: Krzysztof Lecki klecki@nvidia.com#### Why we need this PR?
What happened in this PR?
馃憖 spot no license, add it
Python tests.
None, just please remember to add them
CI
Nope
JIRA TASK: [NA]