Make not schedule any pipeline run when the iterator has prepare_first_batch=False
#2859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st_batch=False` - fixes the FW iterator behavior when `prepare_first_batch=False`. It used to run prefetch on the pipeline even when set to `False`. - adds an appropriate test case Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
!build |
|
CI MESSAGE: [2263079]: BUILD STARTED |
jantonguirao
approved these changes
Apr 13, 2021
| def test_paddle_prepare_first_batch(): | ||
| from nvidia.dali.plugin.paddle import DALIGenericIterator as PaddleIterator | ||
| check_prepare_first_batch(PaddleIterator, output_map=["data"], | ||
| to_np=lambda x: np.array(x["data"])) |
There was a problem hiding this comment.
add line break at the end
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
CI MESSAGE: [2263079]: BUILD PASSED |
awolant
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prepare_first_batch=False. It used torun prefetch on the pipeline even when set to
False.Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com
Why we need this PR?
Pick one, remove the rest
prepare_first_batch=FalseWhat happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
fixes the FW iterator behavior when
prepare_first_batch=False. It used to run prefetch on the pipeline even when set toFalse.base_iterator.py
test_fw_iterators.py
NA
adds an appropriate test case
No
JIRA TASK: [ NA]