Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Composite resource + renaming. #2891

Merged
merged 2 commits into from
Apr 23, 2021
Merged

Composite resource + renaming. #2891

merged 2 commits into from
Apr 23, 2021

Conversation

mzient
Copy link
Contributor

@mzient mzient commented Apr 21, 2021

Signed-off-by: Michał Zientkiewicz mzient@gmail.com

Why we need this PR?

Pick one, remove the rest

  • It adds new feature: composite resource needed to couple lifetime of a resource with its dependencies.

What happened in this PR?

Fill relevant points, put NA otherwise. Replace anything inside []

  • What solution was applied:
    • Added a class which aggregates a memory resource and some extra data (e.g. upstreams)
    • Renamed stream_aware_memory_resource to a much shorter async_memory_resource.
  • Affected modules and functionalities:
    • Memory manager
  • Key points relevant for the review:
    • N/A
  • Validation and testing:
    • GTest
  • Documentation (including examples):
    • Comments

JIRA TASK: DALI-1813

@mzient mzient requested a review from a team April 21, 2021 17:58
@mzient
Copy link
Contributor Author

mzient commented Apr 21, 2021

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2291469]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2291469]: BUILD FAILED

@mzient
Copy link
Contributor Author

mzient commented Apr 22, 2021

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2294060]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2294060]: BUILD FAILED

@mzient
Composite resource + renaming.
a65c2e2 
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
@mzient
Review issues.
a25e3b2 
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
@mzient
Copy link
Contributor Author

mzient commented Apr 22, 2021

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2295268]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2295268]: BUILD PASSED

@mzient mzient merged commit 1fb472f into NVIDIA:master Apr 23, 2021
@JanuszL JanuszL mentioned this pull request May 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanuszL JanuszL JanuszL approved these changes

@awolant awolant awolant approved these changes

Assignees

@JanuszL JanuszL

@awolant awolant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mzient @dali-automaton @JanuszL @awolant