Allow to specify optional args of Python-only types #2898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!build |
|
CI MESSAGE: [2298905]: BUILD STARTED |
banasraf
approved these changes
Apr 23, 2021
jantonguirao
approved these changes
Apr 23, 2021
mzient
approved these changes
Apr 23, 2021
Schema optional args were defined by providing a type in a template call. Not all DALIDataType values have a C++ type registered for them. Add an overload that allows to use the DALIDataType value directly. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
klecki
force-pushed
the
optional-non-existing
branch
from
3d6793c
to
06f93ae
Compare
|
!build |
|
CI MESSAGE: [2299031]: BUILD STARTED |
|
CI MESSAGE: [2299031]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Schema optional args were defined by providing
a type in a template call. Not all DALIDataType values
have a C++ type registered for them.
Add an overload that allows to use the DALIDataType value directly.
Signed-off-by: Krzysztof Lecki klecki@nvidia.com
Why we need this PR?
Fix bug in schema docs, enable non-C++ types.
What happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
Add an overload for AddOptionalArg that allows to use the DALIDataType value directly.
Schema, numba
N/A
CI, 馃憖
numba setup_fn
JIRA TASK: [Use DALI-XXXX or NA]