Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stream 0 in VideoDecoder when running driver >460 / CUDA >= 11.3. #2902

Merged
merged 3 commits into from
Apr 27, 2021

Conversation

mzient
Copy link
Contributor

@mzient mzient commented Apr 26, 2021

Signed-off-by: Michał Zientkiewicz mzient@gmail.com

Why we need this PR?

Pick one, remove the rest

  • It fixes a bug: crash when running 2 video decoders in parallel.

What happened in this PR?

Fill relevant points, put NA otherwise. Replace anything inside []

  • What solution was applied:
    • Detect driver version >460 or driver CUDA version >= 11.3 and use default stream
  • Affected modules and functionalities:
    • NVDEC
    • dali_operators linkage (added dependency on dynlink_nvml)
  • Key points relevant for the review:
    • N/A
  • Validation and testing:
    • Existing tests cover it
  • Documentation (including examples):
    • N/A

JIRA TASK: [DALI-1973]

Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
@mzient mzient requested a review from a team April 26, 2021 14:22
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
@mzient
Copy link
Contributor Author

mzient commented Apr 26, 2021

!build

@mzient mzient changed the title Use stream 0 when running driver >460 / CUDA >= 11.3. Use stream 0 in VideoDecoder when running driver >460 / CUDA >= 11.3. Apr 26, 2021
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2305518]: BUILD STARTED

@JanuszL JanuszL self-assigned this Apr 26, 2021
#else
{
int driver_cuda_version = 0;
CUDA_CALL(cuDriverGetVersion(&driver_cuda_version));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't use this in all cases?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we'll be able to cut it off somewhere between versions that differ in supported CUDA version. If it coincides, we can drop NVML part.

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2305518]: BUILD PASSED

@awolant awolant self-assigned this Apr 27, 2021
Copy link
Contributor

@awolant awolant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would be good to add runtime warning, when this is triggered?

Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
@mzient
Copy link
Contributor Author

mzient commented Apr 27, 2021

Maybe it would be good to add runtime warning, when this is triggered?

Done.

@mzient
Copy link
Contributor Author

mzient commented Apr 27, 2021

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2308934]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2308934]: BUILD PASSED

@mzient mzient merged commit 903afde into NVIDIA:master Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants