Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs and rename numba_func to numba_function #2903

Merged
merged 1 commit into from
Apr 26, 2021

Conversation

klecki
Copy link
Contributor

@klecki klecki commented Apr 26, 2021

  • Remove automatic listing of all contents of nvidia.dali.plugin
    from supported ops
  • Add layer of experimental for numba plugin for NumbaFunc
  • Rename NumbaFunc to NumbaFunction to match PythonFunction
  • Small fixups

Signed-off-by: Krzysztof Lecki klecki@nvidia.com

Why we need this PR?

Fix docs and add self consistency in DALI naming

What happened in this PR?

  • What solution was applied:
    • Remove automatic listing of all contents of nvidia.dali.plugin
      from supported ops
  • Add layer of experimental for numba plugin for NumbaFunc
  • Rename NumbaFunc to NumbaFunction to match PythonFunction
  • Small fixups
  • Affected modules and functionalities:
    Numba function & docs
  • Key points relevant for the review:
    Missed renames?
  • Validation and testing:
    Plz check the generated docs.
  • Documentation (including examples):
    Yes, mostly keeping numba_function to fn docs and NumbaFunction to ops doc.

JIRA TASK: [Use DALI-XXXX or NA]

* Remove automatic listing of all contents of nvidia.dali.plugin
  from supported ops
* Add layer of experimental for numba plugin for NumbaFunc
* Rename NumbaFunc to NumbaFunction to match PythonFunction
* Small fixups

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
@klecki
Copy link
Contributor Author

klecki commented Apr 26, 2021

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2305538]: BUILD STARTED

Copy link
Contributor

@majra20 majra20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If nosetests --nocapture dali/test/python/test_operator_numba_func.py passes then it's good to go.

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2305538]: BUILD PASSED

@klecki klecki merged commit 888dd9f into NVIDIA:master Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants