Refactor TF Dataset code and lint it #2909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract the dataset and iterator classes out of being nested in DALIDatasetOp kernel Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
|
!build |
|
CI MESSAGE: [2310348]: BUILD STARTED |
|
CI MESSAGE: [2310348]: BUILD FAILED |
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
|
CI MESSAGE: [2313371]: BUILD STARTED |
|
CI MESSAGE: [2313371]: BUILD PASSED |
szalpal
approved these changes
Apr 29, 2021
awolant
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract the dataset and iterator classes
out of being nested in DALIDatasetOp kernel.
Enable linting in dali_tf_plugin and apply fixes.
Signed-off-by: Krzysztof Lecki klecki@nvidia.com
Why we need this PR?
What happened in this PR?
Linter was turend on,
Code was un-nested and dataset split into .h and .cc file
Code was reformatted.
TF Dataset <- only source code rearrangement.
Only linter and build scripts contain meaningful changes.
NA
CI
Not really.
JIRA TASK: [Use DALI-XXXX or NA]