Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make dynlink_xxx use a fixed function to load symbols. #2931

Merged
merged 2 commits into from
May 6, 2021
Merged

Make dynlink_xxx use a fixed function to load symbols. #2931

merged 2 commits into from
May 6, 2021

Conversation

mzient
Copy link
Contributor

@mzient mzient commented May 6, 2021

Signed-off-by: Michał Zientkiewicz mzient@gmail.com

Why we need this PR?

Pick one, remove the rest

  • It fixes a problem: requirement to call a specific function first in order to use the library.

What happened in this PR?

Fill relevant points, put NA otherwise. Replace anything inside []

  • What solution was applied:
    • Use a named, public function to load symbols
  • Affected modules and functionalities:
    • dynlink_cuda
    • dynlink_nvml
    • dynlink_cufile
    • dynlink_nvcuvid
  • Key points relevant for the review:
    • N/A
  • Validation and testing:
    • Existing tests apply
  • Documentation (including examples):
    • N/A

JIRA TASK: N/A

@mzient
* dynlink_xxx now directly links to XxxLoadSymbol instead of having a…
a5958f4 
… setter

Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
@mzient mzient requested a review from a team May 6, 2021 10:00
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2341083]: BUILD STARTED

@jantonguirao jantonguirao self-assigned this May 6, 2021
@mzient
Remove cufileInit.
a46558c 
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2341083]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2341168]: BUILD STARTED

@JanuszL JanuszL self-assigned this May 6, 2021
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2341168]: BUILD PASSED

@mzient mzient merged commit 1e68f6e into NVIDIA:master May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jantonguirao jantonguirao jantonguirao approved these changes

@JanuszL JanuszL JanuszL approved these changes

Assignees

@jantonguirao jantonguirao

@JanuszL JanuszL

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mzient @dali-automaton @jantonguirao @JanuszL