Add launch bounds to TransposeBatch kernel to avoid cudaErrorLaunchOutOfResources #2971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tOfResources - adds launch bounds to TransposeBatch kernel inside fft_postprocess.cuh to make sure that cudaErrorLaunchOutOfResources on some GPUs Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
!build |
|
CI MESSAGE: [2382032]: BUILD STARTED |
|
CI MESSAGE: [2382036]: BUILD STARTED |
|
CI MESSAGE: [2382037]: BUILD STARTED |
|
CI MESSAGE: [2382037]: BUILD PASSED |
|
CI MESSAGE: [2382036]: BUILD PASSED |
|
CI MESSAGE: [2382032]: BUILD FAILED |
|
CI MESSAGE: [2382032]: BUILD PASSED |
mzient
reviewed
May 19, 2021
| @@ -143,7 +143,9 @@ __global__ void ConvertTimeMajorSpectrogram( | |||
| } | |||
|
|
|||
| template <typename Out, typename In, typename Convert = identity> | |||
| __global__ void TransposeBatch( | |||
| __global__ void | |||
| __launch_bounds__(32*kBlock) | |||
There was a problem hiding this comment.
Suggested change
| __launch_bounds__(32*kBlock) | |
| __launch_bounds__(kBlock*kBlock) |
That's how this kernel is invoked in L345 - but now that I look at it, it would make sense to modify it a tiny bit (not in this PR, I guess).
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
!build |
klecki
approved these changes
May 19, 2021
|
CI MESSAGE: [2386250]: BUILD STARTED |
|
CI MESSAGE: [2386250]: BUILD PASSED |
mzient
approved these changes
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sure that cudaErrorLaunchOutOfResources on some GPUs
Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com
Why we need this PR?
Pick one, remove the rest
sure that cudaErrorLaunchOutOfResources on some GPUs
What happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
adds launch bounds to TransposeBatch kernel inside fft_postprocess.cuh to make sure that cudaErrorLaunchOutOfResources on some GPUs
fft_postprocess.cuh
NA
CI
NA
JIRA TASK: [NA]