Numba function operator, docs update #2972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanuszL
reviewed
May 18, 2021
| @@ -112,7 +112,8 @@ This function must work in Numba ``nopython`` mode.)code", DALI_PYTHON_OBJECT) | |||
| This function is invoked once per batch. Also this function must work in Numba ``nopython`` mode.)code", | |||
| DALI_PYTHON_OBJECT, nullptr) | |||
| .AddOptionalArg("batch_processing", R"code(Determines whether the function is invoked once per batch or | |||
| separately for every sample in the batch.)code", false); | |||
| separately for every sample in the batch. For CPU usage we recommend not using this option. When operator | |||
There was a problem hiding this comment.
Suggested change
| separately for every sample in the batch. For CPU usage we recommend not using this option. When operator | |
| separately for every sample in the batch. | |
| The best performance for the CPU is obtained when this option is turned off. When operator |
majra20
force-pushed
the
numba_func_batch_processing_doc
branch
from
bb47c12
to
5af3a1e
Compare
JanuszL
approved these changes
May 19, 2021
mzient
reviewed
May 19, 2021
|
!build |
|
CI MESSAGE: [2385958]: BUILD STARTED |
mzient
reviewed
May 19, 2021
mzient
reviewed
May 19, 2021
| @@ -131,7 +134,7 @@ DALI_SCHEMA(NumbaFuncImpl) | |||
| .AddOptionalArg<int>("setup_fn", R"code(Address of setup function setting shapes for outputs. | |||
| This function is invoked once per batch.)code", 0) | |||
| .AddOptionalArg("batch_processing", R"code(Determines whether the function is invoked once per batch or | |||
| separately for every sample in the batch.)code", false); | |||
| separately for each sample in the batch.)code", false); | |||
There was a problem hiding this comment.
Shouldn't the explanation be here, too?
There was a problem hiding this comment.
Perhaps it should be here only.
There was a problem hiding this comment.
This isn't shown in our documentation, it has MakeInternal() option.
|
CI MESSAGE: [2385958]: BUILD PASSED |
added 4 commits
May 20, 2021 09:45
Signed-off-by: Rafal Maj <rmaj@nvidia.com>
Signed-off-by: Rafal Maj <rmaj@nvidia.com>
Signed-off-by: Rafal Maj <rmaj@nvidia.com>
Signed-off-by: Rafal Maj <rmaj@nvidia.com>
majra20
force-pushed
the
numba_func_batch_processing_doc
branch
from
521a3be
to
9a68f04
Compare
|
!build |
|
CI MESSAGE: [2390222]: BUILD STARTED |
|
CI MESSAGE: [2390222]: BUILD PASSED |
jantonguirao
approved these changes
May 25, 2021
Signed-off-by: Rafal Maj <rmaj@nvidia.com>
|
!build |
|
CI MESSAGE: [2405397]: BUILD STARTED |
|
CI MESSAGE: [2405397]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rafal Maj rmaj@nvidia.com
Why we need this PR?
Pick one, remove the rest
What happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
[ Explain solution of the problem, a new feature added here. ]
[ Describe here what was changed, added, removed. ]
[ Describe here what is the most important part that reviewers should focus on. ]
[ Describe here if and how this PR is tested. ]
[ Describe here if documentation and examples were updated. ]
JIRA TASK: [Use DALI-XXXX or NA]