Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a link to the DALI roadmap in the main readme and the documentation #2979

Merged
merged 2 commits into from
May 20, 2021

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented May 19, 2021

Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com

Why we need this PR?

Pick one, remove the rest

  • It adds a link to the DALI roadmap in the main readme and the documentation

What happened in this PR?

Fill relevant points, put NA otherwise. Replace anything inside []

  • What solution was applied:
    adds a link to the DALI roadmap in the main readme and the documentation
  • Affected modules and functionalities:
    documentation index page, main README
  • Key points relevant for the review:
    NA
  • Validation and testing:
    CI
  • Documentation (including examples):
    only documentation is affected

JIRA TASK: [DALI-2091]

@jantonguirao jantonguirao assigned klecki and jantonguirao and unassigned klecki May 20, 2021
README.rst Outdated
We strongly encourage you to comment on our roadmap and provide us feedback on the mentioned
GitHub issue.

... |dali-roadmap-link| replace:: The following represents
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like too many dots, something is broken: https://github.com/JanuszL/DALI/blob/add_roadmap/README.rst

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
README.rst Outdated
We strongly encourage you to comment on our roadmap and provide us feedback on the mentioned
GitHub issue.

.. |dali-roadmap-link| replace:: The following represents
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe:

Suggested change
.. |dali-roadmap-link| replace:: The following represents
.. |dali-roadmap-link| replace:: The following represents issue

Or just link on the issue to keep the github nomenclature?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@klecki
Copy link
Contributor

klecki commented May 20, 2021

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2391352]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2391352]: BUILD PASSED

@JanuszL JanuszL merged commit be5e324 into NVIDIA:main May 20, 2021
@JanuszL JanuszL deleted the add_roadmap branch May 20, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants