NemoAsrLoader: Close file handles after reading metadata #3003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joaquin Anton <janton@nvidia.com>
JanuszL
approved these changes
May 31, 2021
|
!build |
|
CI MESSAGE: [2428010]: BUILD STARTED |
|
CI MESSAGE: [2428010]: BUILD FAILED |
awolant
approved these changes
Jun 1, 2021
|
CI MESSAGE: [2428010]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joaquin Anton janton@nvidia.com
Why we need this PR?
Pick one, remove the rest
What happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
Changed NemoAsrLoader to close audio file handles after reading metadata, then open them again in the prefetching thread when decoding. This is to avoid having too many files open at the same time, causing a system error (large datasets).
NemoAsrReader
NA
NA
NA
JIRA TASK: [Use DALI-XXXX or NA]