Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image decode #3148

Merged
merged 9 commits into from
Jul 16, 2021
Merged

Fix image decode #3148

merged 9 commits into from
Jul 16, 2021

Conversation

cyyever
Copy link
Contributor

@cyyever cyyever commented Jul 12, 2021

Description

  • Bug fix

Describe in detail what happened in this PR

fix memory leak and pointer overflow

@klecki
Copy link
Contributor

klecki commented Jul 13, 2021

Hi @cyyever,
could you fill the relevant parts of PR template instead of removing it?

dali/image/jpeg_mem.cc Outdated Show resolved Hide resolved
dali/image/jpeg_mem.cc Outdated Show resolved Hide resolved
dali/image/bmp.cc Outdated Show resolved Hide resolved
dali/image/jpeg_mem.cc Outdated Show resolved Hide resolved
@cyyever cyyever force-pushed the fix_image_decode branch 2 times, most recently from b95f059 to 167c97a Compare July 13, 2021 14:50
Copy link
Contributor

@mzient mzient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, running CI.

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2581175]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2581175]: BUILD FAILED

dali/image/jpeg_mem.cc Outdated Show resolved Hide resolved
dali/image/jpeg_mem.cc Outdated Show resolved Hide resolved
dali/image/jpeg_mem.cc Outdated Show resolved Hide resolved
cyyever and others added 9 commits July 14, 2021 18:47
Signed-off-by: cyy <cyyever@outlook.com>
Signed-off-by: cyy <cyyever@outlook.com>
Co-authored-by: Michał Zientkiewicz <mzient@gmail.com>
Signed-off-by: cyy <cyyever@outlook.com>
Signed-off-by: cyy <cyyever@outlook.com>
Co-authored-by: Michał Zientkiewicz <mzient@gmail.com>
Signed-off-by: cyy <cyyever@outlook.com>
Signed-off-by: cyy <cyyever@outlook.com>
Co-authored-by: Michał Zientkiewicz <mzient@gmail.com>
Signed-off-by: cyy <cyyever@outlook.com>
Co-authored-by: Michał Zientkiewicz <mzient@gmail.com>
Signed-off-by: cyy <cyyever@outlook.com>
Co-authored-by: Michał Zientkiewicz <mzient@gmail.com>
Signed-off-by: cyy <cyyever@outlook.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2591158]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2591232]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2591158]: BUILD PASSED

@klecki klecki merged commit 5f7bfda into NVIDIA:main Jul 16, 2021
@cyyever cyyever deleted the fix_image_decode branch July 16, 2021 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants