Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transform parameter to convolution cpu #3535

Merged
merged 3 commits into from
Nov 26, 2021

Conversation

stiepan
Copy link
Member

@stiepan stiepan commented Nov 25, 2021

Signed-off-by: Kamil Tokarski ktokarski@nvidia.com

Adds transform parameter to separable convolution and convolution kernel to allow accumulating outputs of several convolutions

Description

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (Redesign of existing code that doesn't affect functionality)
  • Other (e.g. Documentation, Tests, Configuration)

What happened in this PR

Adds transform parameter to separable convolution and convolution kernel to allow accumulating outputs of several convolutions

  • Affected modules and functionalities:

    • Convolution CPU
    • Separable Convolution CPU
  • Key points relevant for the review:
    It is a part of laplacian operator effort.

Checklist

Tests

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: DALI-2481

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
@klecki klecki self-assigned this Nov 25, 2021
Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
@stiepan stiepan mentioned this pull request Nov 26, 2021
23 tasks
@banasraf banasraf self-assigned this Nov 26, 2021
Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
@stiepan
Copy link
Member Author

stiepan commented Nov 26, 2021

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3478299]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3478299]: BUILD PASSED

@stiepan stiepan merged commit 8af5e2b into NVIDIA:main Nov 26, 2021
00max09 pushed a commit to szkarpinski/DALI that referenced this pull request Dec 1, 2021
* Add transform parameter to convolution cpu

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
Signed-off-by: Maksymilian Grochowski <mg417883@students.mimuw.edu.pl>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
* Add transform parameter to convolution cpu

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
* Add transform parameter to convolution cpu

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
* Add transform parameter to convolution cpu

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
* Add transform parameter to convolution cpu

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
* Add transform parameter to convolution cpu

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
* Add transform parameter to convolution cpu

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
* Add transform parameter to convolution cpu

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
* Add transform parameter to convolution cpu

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
* Add transform parameter to convolution cpu

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
* Add transform parameter to convolution cpu

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
* Add transform parameter to convolution cpu

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
* Add transform parameter to convolution cpu

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
* Add transform parameter to convolution cpu

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Feb 21, 2022
* Add transform parameter to convolution cpu

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request May 13, 2022
* Add transform parameter to convolution cpu

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jun 7, 2022
* Add transform parameter to convolution cpu

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants