Fix stream usage in C API #3713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… CPU backen usable without a GPU. Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
JanuszL
reviewed
Mar 1, 2022
| @@ -69,9 +69,27 @@ std::string GetDeviceStr(device_type_t dev) { | |||
| return dev == CPU ? "cpu" : "gpu"; | |||
| } | |||
|
|
|||
| // Allocates a buffer on the specified backend and, if necessary, another one for the CPU | |||
There was a problem hiding this comment.
The only test we run from this file without GPU is CpuOnlyTest - see https://github.com/NVIDIA/DALI/blob/main/qa/TL0_cpu_only/test.sh#L34.
Maybe we should improve the pattern there - or change test naming here to run more CPU only test?
|
CI MESSAGE: [4061845]: BUILD STARTED |
|
CI MESSAGE: [4061845]: BUILD FAILED |
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
|
CI MESSAGE: [4062458]: BUILD STARTED |
|
CI MESSAGE: [4062458]: BUILD FAILED |
jantonguirao
approved these changes
Mar 2, 2022
|
CI MESSAGE: [4062458]: BUILD PASSED |
jantonguirao
added
the
important-fix
|
CI MESSAGE: [4068049]: BUILD STARTED |
|
CI MESSAGE: [4068293]: BUILD STARTED |
|
CI MESSAGE: [4068293]: BUILD FAILED |
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
mzient
force-pushed
the
CAPIFixStreamUsage
branch
from
d088d3c
to
da5e5ae
Compare
|
CI MESSAGE: [4068460]: BUILD STARTED |
JanuszL
reviewed
Mar 2, 2022
| @@ -31,7 +31,7 @@ test_body() { | |||
| exit 1 | |||
| fi | |||
|
|
|||
| "$FULLPATH" --gtest_filter="*CpuOnlyTest*" | |||
| "$FULLPATH" --gtest_filter="*CpuOnly*:*CApi*/0.*-*0.UseCopyKernel:*ForceNoCopyFail:*daliOutputCopySamples" | |||
There was a problem hiding this comment.
Yes - unfortunately the name of the TypeParam is not a part of the name, so you can't match against that.
There was a problem hiding this comment.
You can pls add a comment about that?
|
CI MESSAGE: [4068049]: BUILD PASSED |
JanuszL
approved these changes
Mar 2, 2022
JanuszL
pushed a commit
that referenced
this pull request
Mar 2, 2022
* Fix stream/order usage in C API and tests. Make most C API tests with CPU backen usable without a GPU. * Make C API CpuOnly test only run for CPU backend. * Use AccessOrder in copyX2Y. Add more CPU-only tests. * Extend the range of CPU-only native tests * Adjust cpplint for C++17 structured bindings. Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
|
CI MESSAGE: [4068460]: BUILD PASSED |
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
May 13, 2022
* Fix stream/order usage in C API and tests. Make most C API tests with CPU backen usable without a GPU. * Make C API CpuOnly test only run for CPU backend. * Use AccessOrder in copyX2Y. Add more CPU-only tests. * Extend the range of CPU-only native tests * Adjust cpplint for C++17 structured bindings. Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jun 7, 2022
* Fix stream/order usage in C API and tests. Make most C API tests with CPU backen usable without a GPU. * Make C API CpuOnly test only run for CPU backend. * Use AccessOrder in copyX2Y. Add more CPU-only tests. * Extend the range of CPU-only native tests * Adjust cpplint for C++17 structured bindings. Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Bug fix (non-breaking change which fixes an issue)
Description:
auto [a, b]Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Checklist
Tests
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A