Add supported layouts to Crop, CropMirrorNormalize #3722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzient
reviewed
Mar 7, 2022
dali/pipeline/data/layouts.h
Outdated
| // Layouts containing spatial dimensions such as height, width, depth | ||
| // Contains Image, Volumetric Images, and Sequence layouts | ||
| static std::initializer_list<TensorLayout> kSpatialLayouts { | ||
| "HWC", "CHW", "DHWC", "FHWC", "FCHW", "CDHW", "CFHW", "FDHWC", "FCDHW", "CFDHW" |
There was a problem hiding this comment.
These are not spatial layouts, since they also include temporal dimension.
Also, I don't like mixing such lists into a high-impact (and therefore, high build-time) header.
jantonguirao
force-pushed
the
crop_layouts
branch
from
73bafce
to
fdc5c39
Compare
jantonguirao
changed the title
klecki
approved these changes
Mar 8, 2022
Signed-off-by: Joaquin Anton <janton@nvidia.com>
jantonguirao
force-pushed
the
crop_layouts
branch
from
5f4d19c
to
bd49f8d
Compare
jantonguirao
changed the title
Signed-off-by: Joaquin Anton <janton@nvidia.com>
klecki
approved these changes
Mar 8, 2022
mzient
reviewed
Mar 9, 2022
Comment on lines
37
to
38
| .InputLayout(0, {"HWC", "CHW", "DHWC", | ||
| "FHWC", "FCHW", "CDHW", "CFHW", |
There was a problem hiding this comment.
Nitpick: I know it technically only matters which layout is listed first for any given number of dimensions, but it would be nice to group them as 3D, video (or, conversely: video, 3D).
Suggested change
| .InputLayout(0, {"HWC", "CHW", "DHWC", | |
| "FHWC", "FCHW", "CDHW", "CFHW", | |
| .InputLayout(0, {"HWC", "CHW", "DHWC", "CDHW", | |
| "FHWC", "FCHW","CFHW", |
18 tasks
mzient
approved these changes
Mar 9, 2022
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
|
!build |
|
CI MESSAGE: [4116328]: BUILD STARTED |
|
CI MESSAGE: [4116328]: BUILD PASSED |
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
May 13, 2022
Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jun 7, 2022
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joaquin Anton janton@nvidia.com
Category:
New feature
Description:
Adds layout information to Crop, CropMirrorNormalize. The layout info is used both for documentation and error checking.
Additional information:
Affected modules and functionalities:
Crop, CropMirrorNormalize operators
Key points relevant for the review:
NA
Checklist
Tests
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A