Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gtest RandomBBoxCropTest tests #3822

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Apr 13, 2022

  • removes the native RandomBBoxCropTest module as it doesn't validate
    the results and test_operator_random_bbox_crop.py provides
    the necessary test coverage already

Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com

Category:

Other (e.g. Documentation, Tests, Configuration)

Description:

  • removes the native RandomBBoxCropTest module as it doesn't validate
    the results and test_operator_random_bbox_crop.py provides
    the necessary test coverage already

Additional information:

Affected modules and functionalities:

  • RandomBBoxCropTest tests

Key points relevant for the review:

  • NA

Checklist

Tests

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

- removes the native RandomBBoxCropTest module as it doesn't validate
  the results and test_operator_random_bbox_crop.py provides
  the necessary test coverage already

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@JanuszL
Copy link
Contributor Author

JanuszL commented Apr 13, 2022

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [4501185]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [4501185]: BUILD PASSED

@JanuszL JanuszL merged commit c181a23 into NVIDIA:main Apr 14, 2022
@JanuszL JanuszL deleted the remove_bbox_native_Tests branch April 14, 2022 10:37
cyyever pushed a commit to cyyever/DALI that referenced this pull request May 13, 2022
- removes the native RandomBBoxCropTest module as it doesn't validate
  the results and test_operator_random_bbox_crop.py provides
  the necessary test coverage already

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jun 7, 2022
- removes the native RandomBBoxCropTest module as it doesn't validate
  the results and test_operator_random_bbox_crop.py provides
  the necessary test coverage already

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants