Fix TF DALIDataset tests that changed layout between iterations #3836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DALI assumes that the input will have the dimensionality inferred from the layout passed to external source operator. TF DALIDataset allows to specify input and override the previously specified layout - which could change the dimensionality. As changing the dimensionality is not allowed this leads to error in tests. TODO: Adjust the API by either disallowing to override the layout or allow it only when initial layout is empty. Introduce better error checking that would detect that situation. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
|
CI MESSAGE: [4641619]: BUILD STARTED |
JanuszL
approved these changes
Apr 21, 2022
|
CI MESSAGE: [4642529]: BUILD STARTED |
banasraf
approved these changes
Apr 22, 2022
klecki
changed the title
klecki
changed the title
|
CI MESSAGE: [4649198]: BUILD STARTED |
JanuszL
approved these changes
Apr 22, 2022
|
CI MESSAGE: [4649198]: BUILD PASSED |
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
May 13, 2022
…IA#3836) DALI assumes that the input will have the dimensionality inferred from the layout passed to external source operator. TF DALIDataset allows to specify input and override the previously specified layout - which could change the dimensionality. As changing the dimensionality is not allowed this leads to error in tests. TODO: Adjust the API by either disallowing to override the layout or allow it only when initial layout is empty. Introduce better error checking that would detect that situation. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jun 7, 2022
…IA#3836) DALI assumes that the input will have the dimensionality inferred from the layout passed to external source operator. TF DALIDataset allows to specify input and override the previously specified layout - which could change the dimensionality. As changing the dimensionality is not allowed this leads to error in tests. TODO: Adjust the API by either disallowing to override the layout or allow it only when initial layout is empty. Introduce better error checking that would detect that situation. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category: Bug fix
Description:
DALI assumes that the input will have the dimensionality
inferred from the layout passed to external source operator.
TF DALIDataset allows to specify input and override
the previously specified layout - which could change
the dimensionality. As changing the dimensionality
is not allowed this leads to error in tests.
TODO: Adjust the API by either disallowing
to override the layout or allow it only when initial
layout is empty. Introduce better error checking
that would detect that situation.
Additional information:
Affected modules and functionalities:
TF Test
Key points relevant for the review:
Checklist
Tests
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A