Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo (model -> module) #3848

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Fix typo (model -> module) #3848

merged 1 commit into from
Apr 26, 2022

Conversation

szalpal
Copy link
Member

@szalpal szalpal commented Apr 25, 2022 •
edited

Signed-off-by: szalpal mszolucha@nvidia.com

Category:

Refactoring (Redesign of existing code that doesn't affect functionality)

Description:

This PR fixes a small typo: model -> module (too much Triton development...)

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Checklist

Tests

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@szalpal
Fix typo (model -> module)
423711c 
Signed-off-by: szalpal <mszolucha@nvidia.com>
@szalpal szalpal changed the title Fix typo (model -> module) Fix typo (model -> module) Apr 25, 2022
@szalpal
Copy link
Member Author

szalpal commented Apr 25, 2022

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [4667436]: BUILD STARTED

@JanuszL JanuszL self-assigned this Apr 25, 2022
@awolant awolant self-assigned this Apr 25, 2022
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [4667436]: BUILD PASSED

@szalpal szalpal merged commit e9f4363 into NVIDIA:main Apr 26, 2022
cyyever pushed a commit to cyyever/DALI that referenced this pull request May 13, 2022
@szalpal @cyyever
Fix typo (model -> module) (NVIDIA#3848)
7eccaab 
Signed-off-by: szalpal <mszolucha@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jun 7, 2022
@szalpal @cyyever
Fix typo (model -> module) (NVIDIA#3848)
ed89adc 
Signed-off-by: szalpal <mszolucha@nvidia.com>
@szalpal szalpal deleted the fix-typo branch February 9, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanuszL JanuszL JanuszL approved these changes

@awolant awolant awolant approved these changes

Assignees

@JanuszL JanuszL

@awolant awolant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@szalpal @dali-automaton @JanuszL @awolant