Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes test_coverage case in test_dali_cpu_only.py and test_dali_variable_batch_size.py #3849

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Apr 25, 2022

  • due to recent changes in fn.operators objects module_functions
    function logic from the test_utils.py stopped working. This PR
    fixes this issue.

Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com

Category:

Bug fix (non-breaking change which fixes an issue)

Description:

  • due to recent changes in fn.operators objects module_functions
    function logic from the test_utils.py stopped working. This PR
    fixes this issue.

Additional information:

Affected modules and functionalities:

  • test_utils.py

Key points relevant for the review:

  • NA

Checklist

Tests

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@JanuszL
Copy link
Contributor Author

JanuszL commented Apr 25, 2022

!build

@klecki klecki self-assigned this Apr 25, 2022
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [4668674]: BUILD STARTED

@stiepan stiepan self-assigned this Apr 25, 2022
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [4668674]: BUILD FAILED

…iable_batch_size.py

- due to recent changes in fn.operators objects module_functions
  function logic from the test_utils.py stopped working. This PR
  fixes this issue.

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@JanuszL
Copy link
Contributor Author

JanuszL commented Apr 26, 2022

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [4678265]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [4678265]: BUILD PASSED

@JanuszL JanuszL merged commit 6a8a680 into NVIDIA:main Apr 26, 2022
@JanuszL JanuszL deleted the fix_test_cov branch April 26, 2022 17:11
cyyever pushed a commit to cyyever/DALI that referenced this pull request May 13, 2022
…iable_batch_size.py (NVIDIA#3849)

- due to recent changes in fn.operators objects module_functions
  function logic from the test_utils.py stopped working. This PR
  fixes this issue.

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jun 7, 2022
…iable_batch_size.py (NVIDIA#3849)

- due to recent changes in fn.operators objects module_functions
  function logic from the test_utils.py stopped working. This PR
  fixes this issue.

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants