Support vector alike output for OpSpec::TryGetRepeatedArgument #3851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzient
reviewed
Apr 26, 2022
awolant
approved these changes
May 4, 2022
prak-nv
changed the title
|
!build |
|
CI MESSAGE: [5033446]: BUILD STARTED |
stiepan
reviewed
Jun 7, 2022
| }; | ||
|
|
||
| template <typename T, typename V1, typename V2> | ||
| inline void copy_vector_impl(V1 &out, const V2 &in); |
There was a problem hiding this comment.
nitpick/question: why not simply define the copy_vector_impl here?
There was a problem hiding this comment.
Artifact of previous version. It can even be inlined now. Will do thanks.
stiepan
approved these changes
Jun 7, 2022
|
CI MESSAGE: [5033446]: BUILD PASSED |
|
!build |
|
CI MESSAGE: [5041790]: BUILD STARTED |
|
CI MESSAGE: [5041790]: BUILD FAILED |
Signed-off-by: Piotr Rak <prak@nvidia.com>
|
!build |
|
CI MESSAGE: [5042247]: BUILD STARTED |
|
CI MESSAGE: [5042247]: BUILD FAILED |
|
CI MESSAGE: [5042247]: BUILD PASSED |
stiepan
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Refactoring (Redesign of existing code that doesn't affect functionality)
Description:
Adds support for output argument to any type with vector interface to OpSpec::TryGetRepeatedArgument.
It is used with
SmallVectorin few cases, but required copy forstd::vector.Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Checklist
Tests
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A