Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated PyTorch-Lightning example with new strategy keyword for Trainer. #3867

Merged
merged 2 commits into from
May 4, 2022
Merged

Updated PyTorch-Lightning example with new strategy keyword for Trainer. #3867

merged 2 commits into from
May 4, 2022

Conversation

jasonxzhou
Copy link
Contributor

Signed-off-by: Jason Zhou jasonzhou@berkeley.edu

Category:

Refactoring (Redesign of existing code that doesn't affect functionality)

Description:

Update PyTorch-Lightning framework example to use correct keyword argument for distributed training strategies (distributed_backend -> strategy).

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Checklist

Tests

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

Signed-off-by: Jason Zhou <jasonzhou@berkeley.edu>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@JanuszL JanuszL self-assigned this Apr 28, 2022
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@JanuszL
Copy link
Contributor

JanuszL commented Apr 29, 2022

@jasonxzhou - I have pushed a commit that updates this example in two more places.

@JanuszL
Copy link
Contributor

JanuszL commented Apr 29, 2022

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [4709034]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [4709034]: BUILD FAILED

@JanuszL
Copy link
Contributor

JanuszL commented Apr 29, 2022

There is a problem with our CI. I will rerun the tests when it up and running again.

@JanuszL
Copy link
Contributor

JanuszL commented May 4, 2022

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [4745868]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [4745868]: BUILD PASSED

@JanuszL JanuszL merged commit b4c801e into NVIDIA:main May 4, 2022
@JanuszL
Copy link
Contributor

JanuszL commented May 4, 2022

@jasonxzhou - thank you for your help.

cyyever pushed a commit to cyyever/DALI that referenced this pull request May 13, 2022
…er. (NVIDIA#3867)

Signed-off-by: Jason Zhou <jasonzhou@berkeley.edu>
Co-authored-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jun 7, 2022
…er. (NVIDIA#3867)

Signed-off-by: Jason Zhou <jasonzhou@berkeley.edu>
Co-authored-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants