Add tutorials references to ops docs - general section #3869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Albert Wolant <awolant@nvidia.com>
|
!build |
JanuszL
reviewed
May 4, 2022
| "tensor_join.ipynb", | ||
| op_reference('fn.cat', "Tutorial describing tensor joining")), | ||
| doc_entry( | ||
| "reinterpret.ipynb", |
There was a problem hiding this comment.
I think you should add squeeze, expand_dims and reinterpret as this tutorial describes them as well.
JanuszL
reviewed
May 4, 2022
| "reductions.ipynb", | ||
| op_reference('fn.reductions', "Tutorial describing how to use reductions")), | ||
| doc_entry( | ||
| "tensor_join.ipynb", |
There was a problem hiding this comment.
I think you need to list stack here as well.
|
CI MESSAGE: [4747915]: BUILD STARTED |
Signed-off-by: Albert Wolant <awolant@nvidia.com>
|
CI MESSAGE: [4747915]: BUILD PASSED |
JanuszL
approved these changes
May 4, 2022
JanuszL
reviewed
May 4, 2022
Comment on lines
26
to
28
| op_reference('fn.transforms', "Tutorial describing tensor geometric transformations"), | ||
| op_reference('fn.warp_affine', "Tutorial describing tensor geometric transformations"), | ||
| op_reference('fn.coord_transform', "Tutorial describing tensor geometric transformations")]), |
There was a problem hiding this comment.
This is just point of view. Maybe we can a bit farther and write which particular aspect this tutorial is touching, like:
Suggested change
| op_reference('fn.transforms', "Tutorial describing tensor geometric transformations"), | |
| op_reference('fn.warp_affine', "Tutorial describing tensor geometric transformations"), | |
| op_reference('fn.coord_transform', "Tutorial describing tensor geometric transformations")]), | |
| op_reference('fn.transforms', "Tutorial describing tensor geometric transformations to transform points and images"), | |
| op_reference('fn.warp_affine', "Tutorial showing how to use afine transform"), | |
| op_reference('fn.coord_transform', "Tutorial describing how to transform points accompanying images")]), |
Signed-off-by: Albert Wolant <awolant@nvidia.com>
JanuszL
approved these changes
May 4, 2022
|
!build |
|
CI MESSAGE: [4750729]: BUILD STARTED |
|
CI MESSAGE: [4750729]: BUILD PASSED |
szalpal
approved these changes
May 10, 2022
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
May 13, 2022
* Add tutorials references to ops docs Signed-off-by: Albert Wolant <awolant@nvidia.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jun 7, 2022
* Add tutorials references to ops docs Signed-off-by: Albert Wolant <awolant@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Albert Wolant awolant@nvidia.com
Category:
Refactoring: Add tutorials references to ops docs - general section
Description:
Add tutorials references to ops docs - general section
Additional information:
Affected modules and functionalities:
Docs
Key points relevant for the review:
Are proper ops referenced
Checklist
Tests
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: DALI-2718