Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce libaviutils log verbosity to errors and above #3871

Merged
merged 2 commits into from
May 6, 2022

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented May 5, 2022

  • sets log level in libaviutils from warning to error and above
    (that includes fatal and panic)

Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com

Category:

Other (e.g. Documentation, Tests, Configuration)

Description:

  • sets log level in libaviutils from warning to error and above
    (that includes fatal and panic)

Additional information:

Affected modules and functionalities:

  • video reader

Key points relevant for the review:

  • NA

Checklist

Tests

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

Relates to #3870

- sets log level in libaviutils from warning to error and above
  (that includes fatal and panic)

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@JanuszL
Copy link
Contributor Author

JanuszL commented May 5, 2022

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [4760847]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [4760847]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [4760847]: BUILD PASSED

@@ -87,7 +87,7 @@ FramesDecoderGpu::FramesDecoderGpu(const std::string &filename, cudaStream_t str
CUDA_CALL(cuvidCreateVideoParser(&nvdecode_state_->parser, &parser_info));

// Init internal frame buffer
// TODO(awolant): Check, if continous buffer would be faster
// TODO(awolant): Check, if continuos buffer would be faster
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// TODO(awolant): Check, if continuos buffer would be faster
// TODO(awolant): Check, if continuous buffer would be faster

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@JanuszL
Copy link
Contributor Author

JanuszL commented May 6, 2022

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [4767185]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [4767185]: BUILD PASSED

@JanuszL JanuszL merged commit bbde2ac into NVIDIA:main May 6, 2022
@JanuszL JanuszL deleted the ffmpeg_log_verbs branch May 6, 2022 13:20
cyyever pushed a commit to cyyever/DALI that referenced this pull request May 13, 2022
- sets log level in libaviutils from warning to error and above
  (that includes fatal and panic)

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jun 7, 2022
- sets log level in libaviutils from warning to error and above
  (that includes fatal and panic)

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants